ok with some more research today it seems the difference and issues I was
having was from the patch being made with
git diff vs git format-patch
with git diff (which is how the patch I was reviewing was made) you apply
doing "patch -p1 < patch"
no commits messages are preserved with git diff. I think there are pros
and cons to this.
If folks make good commit messages then this is great however I prefer the
git diff patch myself from contribs because then I can commit with a
message for the JIRA ticket and the reviewer
thoughts on git diff vs git format-patch ?
I updated the wiki to deal with the error i encountered since it already
references format-patch I but think we should have some consensus for
contributors and how they should proceed and how we should too.
On Sat, Jan 5, 2013 at 2:02 PM, Joe Stein <[EMAIL PROTECTED]> wrote:
Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>