Neha Narkhede 2013-09-08, 16:59
Neha Narkhede 2013-09-09, 16:34
-Re: Review Request 14013: Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x
This is an automatically generated e-mail. To reply, visit:
I am wondering if there is any performance degradation due to the changes in implicit conversion. Could you run kafka.perf.ProducerPerformance and see if there is any noticeable performance change with and w/o the patch?
Could you move the import of the JavaConversion to within this function to limit the scope of the implicit conversion?
Don't you need to specify the java return type explicitly here?
How does this affect IDEs like Intellij? Are you able to build the project in IDE with both version of threadsafe annotation?
- Jun Rao
On Sept. 8, 2013, 9:47 p.m., Christopher Freeman wrote:
Neha Narkhede 2013-09-09, 16:41
Neha Narkhede 2013-09-09, 16:23