Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Kafka >> mail # dev >> [jira] [Commented] (KAFKA-671) DelayedProduce requests should not hold full producer request data


+
Sriram Subramanian 2013-01-15, 19:16
+
Neha Narkhede 2013-01-21, 18:34
+
Jay Kreps 2013-01-30, 07:07
+
Sriram Subramanian 2013-01-31, 18:49
Copy link to this message
-
[jira] [Commented] (KAFKA-671) DelayedProduce requests should not hold full producer request data

    [ https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571360#comment-13571360 ]

Jay Kreps commented on KAFKA-671:
---------------------------------

I think hacking requestObj is fine as an intermediate step but we need a plan to get rid of it in 0.8. Jun what's the plan? I am +1 when we have figured that out.

One nit pick in the current code is:
     val requestObj: RequestOrResponse = RequestKeys.deserializerForKey(requestId)(buffer)
     buffer.rewind()
+    buffer = null

Why are we keeping the buffer around at all if we immediately null it out (and we probably don't need to rewind it first)...?
                
> DelayedProduce requests should not hold full producer request data
> ------------------------------------------------------------------
>
>                 Key: KAFKA-671
>                 URL: https://issues.apache.org/jira/browse/KAFKA-671
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Joel Koshy
>            Assignee: Sriram Subramanian
>            Priority: Blocker
>              Labels: bugs, p1
>             Fix For: 0.8.1
>
>         Attachments: outOfMemFix-v1.patch, outOfMemFix-v2.patch, outOfMemFix-v2-rebase.patch, outOfMemFix-v3.patch
>
>
> Per summary, this leads to unnecessary memory usage.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

 
+
Jun Rao 2013-02-23, 19:48
+
Neha Narkhede 2013-02-25, 21:30