Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka, mail # dev - Review Request 20272: Patch for KAFKA-1356


Copy link to this message
-
Re: Review Request 20272: Patch for KAFKA-1356
Neha Narkhede 2014-04-12, 20:48

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20272/#review40214

core/src/main/scala/kafka/server/KafkaApis.scala
<https://reviews.apache.org/r/20272/#comment73148>

    It seems like the code will be cleaner if we pull MetadataCache into it's own file.

core/src/main/scala/kafka/server/KafkaApis.scala
<https://reviews.apache.org/r/20272/#comment73150>

    This is a little awkwardly named and is only used by addPartitionInfo. How about just leaving it in there?

core/src/main/scala/kafka/server/KafkaApis.scala
<https://reviews.apache.org/r/20272/#comment73149>

    should we remove this comment?
- Neha Narkhede
On April 11, 2014, 9:03 p.m., Jun Rao wrote: