Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka, mail # dev - Review Request 17987: Followup patch incorporting Jay's suggestions


Copy link to this message
-
Re: Review Request 17987: Followup patch incorporting Jay's suggestions
Jay Kreps 2014-02-12, 03:47

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17987/#review34260

clients/src/test/java/org/apache/kafka/clients/producer/PartitionerTest.java
<https://reviews.apache.org/r/17987/#comment64294>

    This is good, can you break it into another test. Something like testRoundRobinIsFair()?
    
    Also can you remove the repeated code. Should be something like
    val part = partitioner.partition(...)
    assertEquals((n + i) % 2, part)
- Jay Kreps
On Feb. 12, 2014, 3:14 a.m., Guozhang Wang wrote: