Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka, mail # dev - Review Request 17055: Patch for KAFKA-1055


Copy link to this message
-
Re: Review Request 17055: Patch for KAFKA-1055
Joel Koshy 2014-01-17, 19:06

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17055/#review32174
-----------------------------------------------------------
Looks good - should we add a separate metric for any dropped messages?

- Joel Koshy
On Jan. 17, 2014, 6:28 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17055/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2014, 6:28 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1055
>     https://issues.apache.org/jira/browse/KAFKA-1055
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1055.v1
>
>
> Diffs
> -----
>
>   core/src/main/scala/kafka/server/KafkaApis.scala 29abc46d22909ac453ee2b50855bf561601496fc
>
> Diff: https://reviews.apache.org/r/17055/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>