Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Review Request 14496: Patch for KAFKA-1073


Copy link to this message
-
Re: Review Request 14496: Patch for KAFKA-1073

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14496/#review26704
-----------------------------------------------------------
Thanks for the patch. I also think deprecating this and adding a --validate option to the reassign partitions tool is a good idea.

- Neha Narkhede
On Oct. 4, 2013, 9:33 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14496/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2013, 9:33 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1073
>     https://issues.apache.org/jira/browse/KAFKA-1073
>
>
> Repository: kafka
>
>
> Description
> -------
>
> kafka-1017
>
>
> Diffs
> -----
>
>   core/src/main/scala/kafka/admin/CheckReassignmentStatus.scala 7e85f87e96dbddf4fd8785ae3960e8fe4813e8e5
>   core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala f333d29bf36bb7fdc66b3bf9af16e7ee19ad7e48
>
> Diff: https://reviews.apache.org/r/14496/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>