Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Review Request 24214: Patch for KAFKA-1374

Copy link to this message
Re: Review Request 24214: Patch for KAFKA-1374

This is an automatically generated e-mail. To reply, visit:
Thanks for the patch. Looks good overall.

Could you run the stress test in TestLogCleaning with compression turned on and see if there is any problem?

    Hmm, I think the original approach of throwing an exception is probably better. When handling the produce requests, we can reject messages w/o a key, if the topic is configured with compaction. Once we do that, there should be no messages with null key during compaction. If that happens, we should just fail the broker.


    Could we use MemoryRecords.RecordsIterator to iterate compressed messages?


    Could this be named compressMessages()?
- Jun Rao
On Aug. 12, 2014, 4:57 p.m., Manikumar Reddy O wrote: