Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Review Request 24214: Patch for KAFKA-1374


Copy link to this message
-
Re: Review Request 24214: Patch for KAFKA-1374

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24214/#review50893
Thanks for the patch. Looks good overall.

Could you run the stress test in TestLogCleaning with compression turned on and see if there is any problem?
core/src/main/scala/kafka/log/LogCleaner.scala
<https://reviews.apache.org/r/24214/#comment88766>

    Hmm, I think the original approach of throwing an exception is probably better. When handling the produce requests, we can reject messages w/o a key, if the topic is configured with compaction. Once we do that, there should be no messages with null key during compaction. If that happens, we should just fail the broker.

core/src/main/scala/kafka/log/LogCleaner.scala
<https://reviews.apache.org/r/24214/#comment88765>

    Could we use MemoryRecords.RecordsIterator to iterate compressed messages?

core/src/main/scala/kafka/log/LogCleaner.scala
<https://reviews.apache.org/r/24214/#comment88763>

    Could this be named compressMessages()?
- Jun Rao
On Aug. 12, 2014, 4:57 p.m., Manikumar Reddy O wrote: