1. Removed --delete from topic command 2. Added config to turn off delete topic (delete.topic.enable)
The reason I chose protecting all public APIs of TopicDeletionManager instead of protecting everything that calls those APIs is only to contain the change. It will be a more widespread and hence risky change to do the latter. Let me know if people think otherwise. Diffs
hmm.. actually the thread will never start since the all the public APIs (including start) of TopicDeletionManager with the delete.topic.enable flag. So this should not be an issue.
Ya, so actually what we return from here when delete topic is disabled doesn't matter since this API is only relevant if topic has been queued up for deletion. Anyhow, I will change it if it is easier to understand. - Neha This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19379/#review37654 On March 18, 2014, 10:32 p.m., Neha Narkhede wrote: