Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka, mail # dev - Review Request 15938: replicas may not have consistent data after becoming follower


Copy link to this message
-
Re: Review Request 15938: replicas may not have consistent data after becoming follower
Neha Narkhede 2013-12-02, 18:44


> On Dec. 2, 2013, 4:55 p.m., Neha Narkhede wrote:
> > core/src/main/scala/kafka/server/KafkaApis.scala, line 396
> > <https://reviews.apache.org/r/15938/diff/1/?file=392699#file392699line396>
> >
> >     We had added the ability for a special consumer to read the replica log for troubleshooting. This patch takes that convenience away. We should probably look for another way to prevent the replica verification tool from giving false negatives. Can it use a different consumer id?
>
> Jun Rao wrote:
>     We could add another debugging consumer mode so that it can read beyond HW. This will complicate the broker side logic a bit though. Also, reading beyond HW always has the danger that the fetched data is garbage since it's truncated. Perhaps we can wait and see if this new mode is really needed?

Yes, we can probably wait. So, if the debugging consumer also reads upto the HW, just like a normal consumer, do we need to have a special "debugging consumer" ?
- Neha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15938/#review29586
-----------------------------------------------------------
On Dec. 1, 2013, 11:33 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15938/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2013, 11:33 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1154
>     https://issues.apache.org/jira/browse/KAFKA-1154
>
>
> Repository: kafka
>
>
> Description
> -------
>
> kafka-1154; fix 1
>
>
> Diffs
> -----
>
>   core/src/main/scala/kafka/api/FetchRequest.scala fb2a2306003ac64a8a3b2fc5fc999e0be273f48d
>   core/src/main/scala/kafka/api/RequestOrResponse.scala b62330be6241c8ff4acd21f0fa7e80b7636e0d42
>   core/src/main/scala/kafka/server/KafkaApis.scala 80a70f1e5e3a7670b2238fe63b8d9e0eac6b46ac
>   core/src/main/scala/kafka/server/ReplicaManager.scala 54f6e1674255f62eba9d90aab0db371c82baf749
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala f1f139e485d98e42be17cdcc327961420cd8c012
>
> Diff: https://reviews.apache.org/r/15938/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>