Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill >> mail # dev >> Contributing!


Copy link to this message
-
Re: Contributing
I added a patch file for issue 221. Please, review the patch and let me know if I need to make any modifications.

Thanks,
Nach

On Sep 9, 2013, at 2:33 PM, Steven Phillips <[EMAIL PROTECTED]> wrote:

> If one of you could submit a patch for the license headers soon, that would
> be great. We want to get this wrapped up soon, but I'd prefer to not repeat
> the work that you have already done.
>
>
> On Mon, Sep 9, 2013 at 7:28 AM, Ted Dunning <[EMAIL PROTECTED]> wrote:
>
>> Second eyes are always good.
>>
>> We need license headers on anything that will stand them.
>>
>> It might be good to have separate patches for different kinds of files.
>>
>>
>> On Mon, Sep 9, 2013 at 7:26 AM, Nachiketa Mishra <[EMAIL PROTECTED]>
>> wrote:
>>
>>> Will do.
>>> On Sep 9, 2013, at 1:28 AM, Yash Sharma <[EMAIL PROTECTED]>
>> wrote:
>>>
>>>> Oh that is great.. I dint check the mail and did it too..
>>>> You killed it first, put a JIRA for it and attach your patch :)
>>>>
>>>> Thanks,
>>>> Yash Sharma
>>>>
>>>>
>>>>
>>>>
>>>> -----Original Message-----
>>>> From: Nachiketa Mishra [mailto:[EMAIL PROTECTED]]
>>>> Sent: Monday, September 09, 2013 1:09 PM
>>>> To: [EMAIL PROTECTED]
>>>> Subject: Re: Contributing
>>>>
>>>> I have all the java files completed. If it helps, I can create a JIRA
>>> issue and upload a patch for java files.
>>>>
>>>> Nach
>>>> On Sep 9, 2013, at 12:31 AM, Yash Sharma <[EMAIL PROTECTED]>
>>> wrote:
>>>>
>>>>> Am free for a while. Let me pick this up :)
>>>>>
>>>>> Thanks,
>>>>> Yash Sharma
>>>>>
>>>>>
>>>>>
>>>>> -----Original Message-----
>>>>> From: Ted Dunning [mailto:[EMAIL PROTECTED]]
>>>>> Sent: Monday, September 09, 2013 11:18 AM
>>>>> To: drill
>>>>> Subject: Re: Contributing
>>>>>
>>>>> To the extent that functions fall into families, code generation makes
>>> a lot of sense.
>>>>>
>>>>> Explicit code without generation may make sense for some functions,
>>> however.
>>>>>
>>>>> Making things more consistent and generally tidying up will always be
>>> welcome, btw.
>>>>>
>>>>> One thing that we are seeing right now is that not all the code has
>>> Apache license headers.  Jumping on that boring task would probably be
>>> widely appreciated.
>>>>>
>>>>>
>>>>>
>>>>> On Sun, Sep 8, 2013 at 10:33 PM, Nachiketa Mishra <[EMAIL PROTECTED]
>>>> wrote:
>>>>>
>>>>>> Hi,
>>>>>> I have been looking at the Drill Functions and the list of functions
>>>>>> that need to be implemented here. The ComparisonFunctions is now in
>>>>>> the codegen section.But, some of the other scalar functions are not
>>>>>> following the code generation template. Are we using Codegen for all
>>>>>> future efforts for Scalar function ?
>>>>>>
>>>>>> I apologize in advance, if this question has been already answered.
>>>>>> Nach
>>>>>>
>>>>>> On Sep 3, 2013, at 11:24 PM, Jacques Nadeau <[EMAIL PROTECTED]>
>>> wrote:
>>>>>>
>>>>>>> We moved those to template compile time generation.   They commented
>>> out
>>>>>>> ones are the old ones.
>>>>>>> On Sep 3, 2013 11:21 PM, "Nachiketa Mishra" <[EMAIL PROTECTED]>
>>> wrote:
>>>>>>>
>>>>>>>> I got a latest from Master branch in github and I see the
>>>>>>>> org.apache.drill.exec.expr.fn.impl.ComparisonFunctions.java (line
>>>>>> 19-565)
>>>>>>>> being commented out. Is there a separate branch that I should be
>>> using ?
>>>>>>>>
>>>>>>>> Nach
>>>>>>>>
>>>>>>>> On Aug 28, 2013, at 9:10 PM, Jacques Nadeau <[EMAIL PROTECTED]>
>>> wrote:
>>>>>>>>
>>>>>>>>> Yes, as is creating new DrillFunc's.  Timothy was nice enough to
>>>>>>>>> put
>>>>>> more
>>>>>>>>> information about DrillFunc's on the wiki: See: the 'Where is a
>>>>>>>>> good
>>>>>>>> place
>>>>>>>>> to start' contributing on this page:
>>>>>>>>> https://cwiki.apache.org/confluence/display/DRILL/Contributing
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Jacques
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Sat, Aug 24, 2013 at 8:10 AM, Nachiketa Mishra
>>>>>>>>> <[EMAIL PROTECTED]
>>>>>>>