Hey devs,

I was testing out 0.92 and HCM got this like this a year ago:

+      if (LOG.isDebugEnabled()) {
+        LOG.debug("expecting "+results.length+" results");
+      }

coming from HBASE-2002 (it's triggered for every processBatchCallback). Was
it intentional? It sure is at DEBUG but since we ship at that logging level
I would suggest removing it.

J-D

+1 to removing it

It was intentional at one point...  :)
But that doesn't mean it should have stayed in the final patch for commit.
On Thu, Oct 6, 2011 at 5:26 PM, Jean-Daniel Cryans <[EMAIL PROTECTED]>wrote:

> Hey devs,
>
> I was testing out 0.92 and HCM got this like this a year ago:
>
> +      if (LOG.isDebugEnabled()) {
> +        LOG.debug("expecting "+results.length+" results");
> +      }
>
> coming from HBASE-2002 (it's triggered for every processBatchCallback). Was
> it intentional? It sure is at DEBUG but since we ship at that logging level
> I would suggest removing it.
>
> J-D
>

+1 on removing it.

On Oct 6, 2011, at 5:26 PM, Jean-Daniel Cryans <[EMAIL PROTECTED]> wrote:

> Hey devs,
>
> I was testing out 0.92 and HCM got this like this a year ago:
>
> +      if (LOG.isDebugEnabled()) {
> +        LOG.debug("expecting "+results.length+" results");
> +      }
>
> coming from HBASE-2002 (it's triggered for every processBatchCallback). Was
> it intentional? It sure is at DEBUG but since we ship at that logging level
> I would suggest removing it.
>
> J-D

Concur, pretty sure I removed this from our internal build, and if not will do so right now.
Best regards,
       - Andy

Problems worthy of attack prove their worth by hitting back. - Piet Hein (via Tom White)
>________________________________
>From: Ted Yu <[EMAIL PROTECTED]>
>To: "[EMAIL PROTECTED]" <[EMAIL PROTECTED]>
>Cc: "[EMAIL PROTECTED]" <[EMAIL PROTECTED]>
>Sent: Friday, October 7, 2011 8:33 AM
>Subject: Re: "expecting X results" spam
>
>+1 on removing it.
>
>
>
>On Oct 6, 2011, at 5:26 PM, Jean-Daniel Cryans <[EMAIL PROTECTED]> wrote:
>
>> Hey devs,
>>
>> I was testing out 0.92 and HCM got this like this a year ago:
>>
>> +      if (LOG.isDebugEnabled()) {
>> +        LOG.debug("expecting "+results.length+" results");
>> +      }
>>
>> coming from HBASE-2002 (it's triggered for every processBatchCallback). Was
>> it intentional? It sure is at DEBUG but since we ship at that logging level
>> I would suggest removing it.
>>
>> J-D
>
>
>