Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: SQOOP-648 Moving localizable strings to resources and consolidate all String constants to Constants.java


+
Venkat Ranganathan 2012-12-01, 16:49
+
Venkat Ranganathan 2012-12-02, 06:11
+
Venkat Ranganathan 2012-12-02, 06:49
+
Jarek Cecho 2012-12-02, 17:07
Copy link to this message
-
Re: Review Request: SQOOP-648 Moving localizable strings to resources and consolidate all String constants to Constants.java
Jarek Cecho 2012-12-03, 18:11


> On Dec. 2, 2012, 5:07 p.m., Jarek Cecho wrote:
> > client/src/main/java/org/apache/sqoop/client/core/ClientError.java, lines 22-45
> > <https://reviews.apache.org/r/8305/diff/3/?file=232795#file232795line22>
> >
> >     Sqoop is currently using common schema for exception all over the place and the named constants are quite important - including the message text. I would suggest to leave the exception handling "as it is" for now and file additional JIRA for translating them. E.g. let's put into resources everything but exceptions.
>
> Venkat Ranganathan wrote:
>     Thanks Jarek.  Will change them including the constants.   But I am not sure I understand about the common schema.  Just trying to understand better.  Is there a table with all the exceptions persisted?

Hi Venkat,
thank you very much for your feedback. Please accept my apology for confusing you. I wasn't talking about database when I've mentioned word schema. I wanted to express that we're currently doing all exceptions across entire code base in exactly the same way and I would prefer to keep doing that. I would suggest to create follow up JIRA and handle localization of exceptions there.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8305/#review13957
-----------------------------------------------------------
On Dec. 2, 2012, 6:49 a.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8305/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2012, 6:49 a.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Description
> -------
>
> I have moved localizable strings to the client resources (those that are descriptions, messages in general etc).  Also consolidated constants to one place and removed repetitive occurrences.  
>
> 4 more files in utils need to be updated, but wanted to get this reviewed and take that after this
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/core/ClientError.java fd3b97d
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java 47c0547
>   client/src/main/java/org/apache/sqoop/client/request/Request.java 1720507
>   client/src/main/java/org/apache/sqoop/client/shell/CloneCommand.java 847a6ad
>   client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java 21c41aa
>   client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java b0e8d90
>   client/src/main/java/org/apache/sqoop/client/shell/CreateCommand.java 2453543
>   client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java 734276d
>   client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java 0b685bf
>   client/src/main/java/org/apache/sqoop/client/shell/DeleteCommand.java bb09bf3
>   client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java ee2a1cf
>   client/src/main/java/org/apache/sqoop/client/shell/DeleteJobFunction.java acc8e21
>   client/src/main/java/org/apache/sqoop/client/shell/HelpCommand.java 03499d8
>   client/src/main/java/org/apache/sqoop/client/shell/SetCommand.java 20c8090
>   client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java 3764306
>   client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java daf1ff4
>   client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java bd74253
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 4e49288
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java a34c48c
>   client/src/main/java/org/apache/sqoop/client/shell/ShowFrameworkFunction.java 8dcf976
>   client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java ee8c63d
>   client/src/main/java/org/apache/sqoop/client/shell/ShowServerFunction.java 039e28b
+
Venkat Ranganathan 2012-12-03, 18:04
+
Venkat Ranganathan 2012-12-05, 07:56
+
Venkat Ranganathan 2012-12-05, 18:41
+
Venkat Ranganathan 2012-12-08, 17:58
+
Jarek Cecho 2012-12-08, 18:57
+
Jarek Cecho 2012-12-08, 15:59
+
Jarek Cecho 2012-12-05, 16:09
+
Jarek Cecho 2012-12-01, 18:49