Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Zookeeper, mail # dev - Re: Review Request 12983: ZOOKEEPER-1691


+
Helen Hastings 2013-08-19, 21:26
+
Edward Ribeiro 2013-08-20, 00:39
+
Helen Hastings 2013-08-21, 22:09
+
Edward Ribeiro 2013-08-20, 02:00
+
Edward Ribeiro 2013-08-20, 02:03
+
Edward Ribeiro 2013-08-20, 02:02
+
Edward Ribeiro 2013-08-20, 02:08
+
Edward Ribeiro 2013-08-20, 02:25
+
Edward Ribeiro 2013-08-20, 02:13
+
Edward Ribeiro 2013-08-20, 02:31
+
Helen Hastings 2013-08-21, 22:11
+
Edward Ribeiro 2013-08-22, 00:14
+
Helen Hastings 2013-08-21, 22:11
+
Alexander Shraer 2013-08-30, 11:11
+
Helen Hastings 2013-10-01, 04:02
+
Alexander Shraer 2013-10-03, 04:54
+
Helen Hastings 2013-12-14, 00:00
+
Helen Hastings 2013-12-14, 00:02
+
Helen Hastings 2014-01-07, 04:32
Copy link to this message
-
Re: Review Request 12983: ZOOKEEPER-1691
Raul Gutierrez Segales 2014-01-17, 18:51

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12983/#review32168
-----------------------------------------------------------

http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java
<https://reviews.apache.org/r/12983/#comment60876>

    nit: if you check all the files in this dir, all the tests are called testFooBar(). Might be good to follow the convention.
    
    See: https://github.com/apache/zookeeper/tree/trunk/src/java/test/org/apache/zookeeper/server/quorum

http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java
<https://reviews.apache.org/r/12983/#comment60880>

    nit: string extrapolation reads more clearly than concatenating strings.
    
    I.e.:
    
    LOG.info("Initial configuration: {}\n", zkHandles[leaderId].getConfig(this, new Stat()));
    
    Plus the cast to string happens for free. Ditto for all other calls to LOG methods.  

http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java
<https://reviews.apache.org/r/12983/#comment60882>

    nit: you can use String.format to make building up this line more readable.
    
    http://docs.oracle.com/javase/7/docs/api/java/lang/String.html#format%28java.lang.String,%20java.lang.Object...%29

http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java
<https://reviews.apache.org/r/12983/#comment60883>

    nit: you can use String.format to make building up this line more readable.
    
    http://docs.oracle.com/javase/7/docs/api/java/lang/String.html#format%28java.lang.String,%20java.lang.Object...%29
- Raul Gutierrez Segales
On Jan. 7, 2014, 4:32 a.m., Helen Hastings wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12983/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2014, 4:32 a.m.)
>
>
> Review request for zookeeper and Alexander Shraer.
>
>
> Repository: zookeeper
>
>
> Description
> -------
>
> Added standaloneEnabled flag to QuorumPeerConfig to give the option to disable standalone mode for a single server.
>
>
> Diffs
> -----
>
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 1545749
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java 1545749
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1545749
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java 1545749
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 1545749
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1545749
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 1545749
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 1545749
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java PRE-CREATION
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ReconfigTest.java 1545749
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/StandaloneTest.java 1545749
>
> Diff: https://reviews.apache.org/r/12983/diff/
>
>
> Testing
> -------
>
>
> Thanks,