Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request: SQOOP-999: Support bulk load from HDFS to PostgreSQL using COPY ... FROM


+
Masatake Iwasaki 2013-06-22, 16:28
Copy link to this message
-
Re: Review Request: SQOOP-999: Support bulk load from HDFS to PostgreSQL using COPY ... FROM

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12048/#review22304
-----------------------------------------------------------
Hi Masatake,
I believe that depending on the PostgreSQL JDBC driver should be fine as long as the licensing is correct. I've took a look and the JDBC Driver is licensed using BSD license that is compatible with ASL and therefore I believe that depending on PostgreSQL JDBC driver should be fine. Please note that this is not the case for majority of other JDBC drivers for other vendors.

I've just read the code (did not tried apply the patch nor run it) and it seems fine to me, so please do not hesitate and continue in the development process!
src/java/org/apache/sqoop/manager/PostgreSQLCopyManager.java
<https://reviews.apache.org/r/12048/#comment45782>

    Since the DirectPostgresqlManager do not implement the exportTable() method, do you think that it would make sense to merge those two connectors into one?

src/java/org/apache/sqoop/manager/PostgreSQLCopyManager.java
<https://reviews.apache.org/r/12048/#comment45781>

    Nit: Trailing whitespace.

src/java/org/apache/sqoop/mapreduce/PostgreSQLCopyMapper.java
<https://reviews.apache.org/r/12048/#comment45783>

    Nit: Trailing whitespace
Jarcec

- Jarek Cecho
On June 22, 2013, 4:28 p.m., Masatake Iwasaki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12048/
> -----------------------------------------------------------
>
> (Updated June 22, 2013, 4:28 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Export with PostgreSQL Copy API can be realized in a straitforward way. Attached file is not complete patch but sample implementation without tests and consideration for corner cases.
> Though this code resolves dependency for PostgreSQL JDBC by ivy, is it acceptable for the project?
>
>
> This addresses bug SQOOP-999.
>     https://issues.apache.org/jira/browse/SQOOP-999
>
>
> Diffs
> -----
>
>   ivy.xml 750adfc
>   ivy/libraries.properties 430d554
>   src/java/org/apache/sqoop/manager/PostgreSQLCopyManager.java PRE-CREATION
>   src/java/org/apache/sqoop/mapreduce/PostgreSQLCopyExportJob.java PRE-CREATION
>   src/java/org/apache/sqoop/mapreduce/PostgreSQLCopyMapper.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12048/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Masatake Iwasaki
>
>

+
Masatake Iwasaki 2013-06-24, 22:10
+
Masatake Iwasaki 2013-06-24, 23:29