-
Re: Review Request: SQOOP-425 Sqoop invokes ResultSet.isLast() which causes Sybase JDBC driver to hangBilung Lee 2012-02-27, 23:34
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4075/#review5370
-----------------------------------------------------------
Ship it!
Thanks for the patch!
- Bilung
On 2012-02-27 23:28:35, Cheolsoo Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4075/
> -----------------------------------------------------------
>
> (Updated 2012-02-27 23:28:35)
>
>
> Review request for Sqoop and Bilung Lee.
>
>
> Summary
> -------
>
> The call to ResultSet.isLast() should be replaced by ResultSet.isAfterLast() where necessary in order to help support Sybase for data import.
>
>
> This addresses bug SQOOP-425.
> https://issues.apache.org/jira/browse/SQOOP-425
>
>
> Diffs
> -----
>
> ./src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java 1294374
>
> Diff: https://reviews.apache.org/r/4075/diff
>
>
> Testing
> -------
>
> Ran ant test
>
>
> Thanks,
>
> Cheolsoo
>
>
