Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Pig >> mail # dev >> Review Request: Patch to address default values when schemas are merged in AvroStorage. It does this for Records containing primitive values


Copy link to this message
-
Re: Review Request: Patch to address default values when schemas are merged in AvroStorage. It does this for Records containing primitive values


> On May 15, 2013, 12:19 a.m., Rohini Palaniswamy wrote:
> > Please fix formatting - spaces instead of tabs and no extra white spaces. This patch will conflict with PIG-3321. Can you merge the changes once that is committed and upload a new patch?

Hi Rohini,
 I have removed all the tabs and merged PIG-3321. Resubmitting again.
Viraj
- Viraj
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11135/#review20552
-----------------------------------------------------------
On May 14, 2013, 1:09 a.m., Viraj Bhat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11135/
> -----------------------------------------------------------
>
> (Updated May 14, 2013, 1:09 a.m.)
>
>
> Review request for pig.
>
>
> Description
> -------
>
> Default values are not honoured when merging default schema
>
>
> This addresses bug PIG-3318.
>     https://issues.apache.org/jira/browse/PIG-3318
>
>
> Diffs
> -----
>
>   http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java 1481245
>   http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java 1481245
>   http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroInputFormat.java 1481245
>   http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java 1481245
>   http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java 1481245
>
> Diff: https://reviews.apache.org/r/11135/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Viraj Bhat
>
>