Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Pig, mail # dev - Review Request: [PIG-3173] - Partition filter pushdown does not happen if partition keys condition include a AND and OR construct


+
Rohini Palaniswamy 2013-03-20, 00:16
+
Dmitriy Ryaboy 2013-03-20, 00:42
+
Dmitriy Ryaboy 2013-03-20, 19:45
+
Rohini Palaniswamy 2013-03-20, 19:02
+
Rohini Palaniswamy 2013-04-29, 20:22
Copy link to this message
-
Re: Review Request: [PIG-3173] - Partition filter pushdown does not happen if partition keys condition include a AND and OR construct
Cheolsoo Park 2013-04-29, 20:51

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10035/#review19891
-----------------------------------------------------------

Ship it!
Looks good to me.

- Cheolsoo Park
On April 29, 2013, 8:22 p.m., Rohini Palaniswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10035/
> -----------------------------------------------------------
>
> (Updated April 29, 2013, 8:22 p.m.)
>
>
> Review request for pig.
>
>
> Description
> -------
>
> 1) Fixed cases where partition pushdown was not happening for AND and OR construct
> 2) Commented out the negative test cases as they were actually not asserting anything.
>
>
> This addresses bug PIG-3173.
>     https://issues.apache.org/jira/browse/PIG-3173
>
>
> Diffs
> -----
>
>   http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/PColFilterExtractor.java 1467858
>   http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestPartitionFilterPushDown.java 1467858
>
> Diff: https://reviews.apache.org/r/10035/diff/
>
>
> Testing
> -------
>
> Unit tests added and tested few cases manually with hcat.
>
>
> Thanks,
>
> Rohini Palaniswamy
>
>