Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: SQOOP-646 Provide support for "set" metadata in Sqoop 2


Copy link to this message
-
Review Request: SQOOP-646 Provide support for "set" metadata in Sqoop 2
Jarek Cecho 2012-11-08, 01:58

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7942/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

I've added new metadata type MEnumInput that is based on java Enum class.
This addresses bug SQOOP-646.
    https://issues.apache.org/jira/browse/SQOOP-646
Diffs
-----

  client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java 96abd42a039cae8a2518f6707cbf49ee6151cc68
  client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java 55d1cc00c080afce6ebc0a9c71a88710a0863ec6
  common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 70fa8bf08f843e084d0b45c7b562eca1d955c020
  common/src/main/java/org/apache/sqoop/model/FormUtils.java ee927189fc84bfc2b076faffb07a2b8ac8552db4
  common/src/main/java/org/apache/sqoop/model/MInput.java 2a87531ee7729d41c4537d714cec23db74053c8f
  common/src/main/java/org/apache/sqoop/model/MInputType.java 80163493bdab6d69edbda7bb08649c36341427f9
  common/src/main/java/org/apache/sqoop/model/MIntegerInput.java 26477cc25bd9509d36f5e305929e2b717d24b849
  common/src/main/java/org/apache/sqoop/model/MMapInput.java de44d3f626bfff4b47d42d6af3985e98b302066c
  common/src/main/java/org/apache/sqoop/model/MStringInput.java 04afb389553557b8c3c2bc2fbe0edb4e35617b4b
  common/src/main/java/org/apache/sqoop/model/ModelError.java d3467c068d5ab9e741473d6c000cfd66cd8ae845
  common/src/main/java/org/apache/sqoop/utils/ClassUtils.java 3f99f59e312ba6fd5d8c281dcdfa8f4d9d0018b2
  common/src/test/java/org/apache/sqoop/utils/TestClassUtils.java f0b0742d7451f88ad5fe52ffb0f39e232cd5c01f
  core/src/main/java/org/apache/sqoop/framework/configuration/ExportJobConfiguration.java 9da513350ef80aca565f258ed3763f7ddd927688
  core/src/main/java/org/apache/sqoop/framework/configuration/ImportJobConfiguration.java de8ddbca44ea68a502ecbcad8061391d96ba1e28
  core/src/main/resources/framework-resources.properties 9f194690467c181c6ce8fa6c813d16b3f2a93115
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 9db1a4bcd30e11ea04f451c0870a29931bcffd4b
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 1f10674604789b3def23cdef5fdbdc09c16fe5b0
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 930544572d794d5ac8e01bac432a007e75ea1571

Diff: https://reviews.apache.org/r/7942/diff/
Testing
-------

I've provided some unit tests and also performed testing on real cluster.
Thanks,

Jarek Cecho

+
Jarek Cecho 2012-11-10, 01:40
+
Bilung Lee 2012-11-10, 02:26