-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7431/
-----------------------------------------------------------

(Updated Jan. 2, 2013, 11:11 p.m.)
Review request for hive and Jakob Homan.
Changes
-------

Added a clientpositive test for all nullable types. Subsumed HIVE-3538, with changes in anticipation of AVRO-997's stricter handling of enums.
Description (updated)
-------

Changes AvroSerDe to properly give the non-null schema to serialization routines when using Nullable complex types. Properly restores the enum-ness of Avro Enums prior to serialization.
Diffs (updated)
-----

  /trunk/data/files/csv.txt PRE-CREATION
  /trunk/ql/src/test/queries/clientpositive/avro_nullable_fields.q PRE-CREATION
  /trunk/ql/src/test/results/clientpositive/avro_nullable_fields.q.out PRE-CREATION
  /trunk/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java 1426606
  /trunk/serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroDeserializer.java 1426606
  /trunk/serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroObjectInspectorGenerator.java 1426606
  /trunk/serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroSerializer.java 1426606

Diff: https://reviews.apache.org/r/7431/diff/
Testing (updated)
-------

Adds tests that check each of the Avro types that Serialization needs to use a user-provided schema, both as top level fields and as nested members of a complex type.

Adds a client positive test that reads in a CSV table with NULLs, copies that data into an Avro backed table, then reads the data out of the table.
Thanks,

Sean Busbey

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7431/#review15161
-----------------------------------------------------------

Ship it!
+1.  Looks great.

- Jakob Homan
On Jan. 2, 2013, 11:11 p.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7431/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2013, 11:11 p.m.)
>
>
> Review request for hive and Jakob Homan.
>
>
> Description
> -------
>
> Changes AvroSerDe to properly give the non-null schema to serialization routines when using Nullable complex types. Properly restores the enum-ness of Avro Enums prior to serialization.
>
>
> Diffs
> -----
>
>   /trunk/data/files/csv.txt PRE-CREATION
>   /trunk/ql/src/test/queries/clientpositive/avro_nullable_fields.q PRE-CREATION
>   /trunk/ql/src/test/results/clientpositive/avro_nullable_fields.q.out PRE-CREATION
>   /trunk/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java 1426606
>   /trunk/serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroDeserializer.java 1426606
>   /trunk/serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroObjectInspectorGenerator.java 1426606
>   /trunk/serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroSerializer.java 1426606
>
> Diff: https://reviews.apache.org/r/7431/diff/
>
>
> Testing
> -------
>
> Adds tests that check each of the Avro types that Serialization needs to use a user-provided schema, both as top level fields and as nested members of a complex type.
>
> Adds a client positive test that reads in a CSV table with NULLs, copies that data into an Avro backed table, then reads the data out of the table.
>
>
> Thanks,
>
> Sean Busbey
>
>