Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume >> mail # dev >> Review Request: FLUME-2036. Make hostname optional for HTTPSource


Copy link to this message
-
Re: Review Request: FLUME-2036. Make hostname optional for HTTPSource

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10984/#review20349
-----------------------------------------------------------

Ship it!
+1

- Mike Percy
On May 7, 2013, 9:52 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10984/
> -----------------------------------------------------------
>
> (Updated May 7, 2013, 9:52 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Made the hostname optional and added default of 0.0.0.0. Added docs and changed the host param to "bind" to match what we do in thrift and avro sources
>
>
> This addresses bug FLUME-2036.
>     https://issues.apache.org/jira/browse/FLUME-2036
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java a96fc0d
>   flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java e7b3c7a
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 83e96f5
>
> Diff: https://reviews.apache.org/r/10984/diff/
>
>
> Testing
> -------
>
> Ran full tests
>
>
> Thanks,
>
> Hari Shreedharan
>
>