Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill, mail # dev - Review Request 14027: Adding Limit operator end to end


Copy link to this message
-
Re: Review Request 14027: Adding Limit operator end to end
Timothy Chen 2013-09-10, 08:29

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14027/
-----------------------------------------------------------

(Updated Sept. 10, 2013, 8:29 a.m.)
Review request for drill and Jacques Nadeau.
Changes
-------

Addressed comments, and also added JdbcTests.
Also fixed the last offset which should be exclusive offset according to plan doc
Repository: drill-git
Description
-------

Adding Limit operator end to end
Diffs (updated)
-----

  common/src/main/java/org/apache/drill/common/logical/data/Limit.java 1774790
  exec/java-exec/src/main/java/org/apache/drill/exec/opt/BasicOptimizer.java c116b59
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java c997db4
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java 97e6795
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/Limit.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java 9984454
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/limit/LimitBatchCreator.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/limit/LimitRecordBatch.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/StatsCollector.java 2ef5295
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestSimpleLimit.java PRE-CREATION
  exec/java-exec/src/test/resources/limit/test1.json PRE-CREATION
  exec/ref/src/main/java/org/apache/drill/exec/ref/rops/LimitROP.java 4a29f94
  sqlparser/pom.xml 84b17a0
  sqlparser/src/main/java/org/apache/drill/optiq/DrillLimitRel.java PRE-CREATION
  sqlparser/src/main/java/org/apache/drill/optiq/DrillLimitRule.java PRE-CREATION
  sqlparser/src/main/java/org/apache/drill/optiq/DrillOptiq.java e687435
  sqlparser/src/main/java/org/apache/drill/optiq/DrillSortRel.java 64995c5
  sqlparser/src/main/java/org/apache/drill/optiq/DrillSortRule.java 0d9852a
  sqlparser/src/test/java/org/apache/drill/jdbc/test/FullEngineTest.java a1a6cf2
  sqlparser/src/test/java/org/apache/drill/jdbc/test/JdbcTest.java 37e81b7

Diff: https://reviews.apache.org/r/14027/diff/
Testing
-------
Thanks,

Timothy Chen