Sqoop, mail # dev - Review Request: SQOOP-888 Sqoop2: Move out checking of special condition token to Validator in Generic JDBC Manager

Review Request: SQOOP-888 Sqoop2: Move out checking of special condition token to Validator in Generic JDBC Manager

Jarek Cecho 2013-02-11, 18:56

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9400/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

I've moved the check to more appropriate location on Validator side.
This addresses bug SQOOP-888.
   https://issues.apache.org/jira/browse/SQOOP-888
Diffs
-----

  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java ad95e6599cb0d6380e62d717e5482958ad4504ab
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java 152eee1e5d48abbd9418de38524d3cc3659c5977

Diff: https://reviews.apache.org/r/9400/diff/
Testing
-------

Unit tests seems to be passing and I've run it on real cluster.
Thanks,

Jarek Cecho

Re: Review Request: SQOOP-888 Sqoop2: Move out checking of special condition token to Validator in Generic JDBC Manager

Cheolsoo Park 2013-02-22, 19:01

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9400/#review16953
-----------------------------------------------------------

Ship it!
Ship It!

- Cheolsoo Park
On Feb. 11, 2013, 6:56 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9400/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2013, 6:56 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've moved the check to more appropriate location on Validator side.
>
>
> This addresses bug SQOOP-888.
> https://issues.apache.org/jira/browse/SQOOP-888
>
>
> Diffs
> -----
>
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java ad95e6599cb0d6380e62d717e5482958ad4504ab
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java 152eee1e5d48abbd9418de38524d3cc3659c5977
>
> Diff: https://reviews.apache.org/r/9400/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing and I've run it on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>