Hi,

The test-patch script in Hadoop source runs a native compile with the
patch. On platforms like MAC, there are issues with the native
compile. For e.g we run into HADOOP-7147 that has been resolved as
Won't fix.

Hence, should we have a switch in test-patch to not run native compile
? Could open a JIRA and fix, if that's OK ?

Thanks
hemanth

Makes sense, though the Jenkins runs should continue to run w/ native, right?

On Thu, Sep 6, 2012 at 12:49 AM, Hemanth Yamijala <[EMAIL PROTECTED]> wrote:
> Hi,
>
> The test-patch script in Hadoop source runs a native compile with the
> patch. On platforms like MAC, there are issues with the native
> compile. For e.g we run into HADOOP-7147 that has been resolved as
> Won't fix.
>
> Hence, should we have a switch in test-patch to not run native compile
> ? Could open a JIRA and fix, if that's OK ?
>
> Thanks
> hemanth

--
Alejandro

Yea we want jenkins to run with native. How about adding making native
optional in test-patch via a flag and updating the jenkins jobs to use
it?

On Thu, Sep 6, 2012 at 7:25 AM, Alejandro Abdelnur <[EMAIL PROTECTED]> wrote:
> Makes sense, though the Jenkins runs should continue to run w/ native, right?
>
> On Thu, Sep 6, 2012 at 12:49 AM, Hemanth Yamijala <[EMAIL PROTECTED]> wrote:
>> Hi,
>>
>> The test-patch script in Hadoop source runs a native compile with the
>> patch. On platforms like MAC, there are issues with the native
>> compile. For e.g we run into HADOOP-7147 that has been resolved as
>> Won't fix.
>>
>> Hence, should we have a switch in test-patch to not run native compile
>> ? Could open a JIRA and fix, if that's OK ?
>>
>> Thanks
>> hemanth
>
>
>
> --
> Alejandro

We could also call "uname" from test-patch.sh and skip running native
tests on Mac OS X.

I also think that HADOOP-7147 should be open rather than "won't fix,"
as Alejandro commented.  Allen Wittenauer closed it as "won't fix"
because he personally did not intend to fix it, but that doesn't mean
it's not a bug.

cheers.
Colin
On Thu, Sep 6, 2012 at 8:29 AM, Eli Collins <[EMAIL PROTECTED]> wrote:
> Yea we want jenkins to run with native. How about adding making native
> optional in test-patch via a flag and updating the jenkins jobs to use
> it?
>
> On Thu, Sep 6, 2012 at 7:25 AM, Alejandro Abdelnur <[EMAIL PROTECTED]> wrote:
>> Makes sense, though the Jenkins runs should continue to run w/ native, right?
>>
>> On Thu, Sep 6, 2012 at 12:49 AM, Hemanth Yamijala <[EMAIL PROTECTED]> wrote:
>>> Hi,
>>>
>>> The test-patch script in Hadoop source runs a native compile with the
>>> patch. On platforms like MAC, there are issues with the native
>>> compile. For e.g we run into HADOOP-7147 that has been resolved as
>>> Won't fix.
>>>
>>> Hence, should we have a switch in test-patch to not run native compile
>>> ? Could open a JIRA and fix, if that's OK ?
>>>
>>> Thanks
>>> hemanth
>>
>>
>>
>> --
>> Alejandro

Thanks. I've opened https://issues.apache.org/jira/browse/HADOOP-8776.
Will work on options and a patch there.

Hemanth

On Fri, Sep 7, 2012 at 12:24 AM, Colin McCabe <[EMAIL PROTECTED]> wrote:
> We could also call "uname" from test-patch.sh and skip running native
> tests on Mac OS X.
>
> I also think that HADOOP-7147 should be open rather than "won't fix,"
> as Alejandro commented.  Allen Wittenauer closed it as "won't fix"
> because he personally did not intend to fix it, but that doesn't mean
> it's not a bug.
>
> cheers.
> Colin
>
>
> On Thu, Sep 6, 2012 at 8:29 AM, Eli Collins <[EMAIL PROTECTED]> wrote:
>> Yea we want jenkins to run with native. How about adding making native
>> optional in test-patch via a flag and updating the jenkins jobs to use
>> it?
>>
>> On Thu, Sep 6, 2012 at 7:25 AM, Alejandro Abdelnur <[EMAIL PROTECTED]> wrote:
>>> Makes sense, though the Jenkins runs should continue to run w/ native, right?
>>>
>>> On Thu, Sep 6, 2012 at 12:49 AM, Hemanth Yamijala <[EMAIL PROTECTED]> wrote:
>>>> Hi,
>>>>
>>>> The test-patch script in Hadoop source runs a native compile with the
>>>> patch. On platforms like MAC, there are issues with the native
>>>> compile. For e.g we run into HADOOP-7147 that has been resolved as
>>>> Won't fix.
>>>>
>>>> Hence, should we have a switch in test-patch to not run native compile
>>>> ? Could open a JIRA and fix, if that's OK ?
>>>>
>>>> Thanks
>>>> hemanth
>>>
>>>
>>>
>>> --
>>> Alejandro