Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Bigtop, mail # user - Code review tools


Copy link to this message
-
Re: Code review tools
Brock Noland 2012-11-28, 20:22
Flume does this, that is patches must be posted on JIRA as well even if
they are on RB.

On Wed, Nov 28, 2012 at 2:11 PM, Konstantin Boudnik <[EMAIL PROTECTED]> wrote:

> To chime in with Bruno earlier - having a review board doesn't mean that
> patches shouldn't posted on JIRAs as we do right now. Otherwise, this
> would be
> an enforcement of the tooling, which I oppose big time.
>
> Cos
>
> On Wed, Nov 28, 2012 at 12:02PM, Jonathan Hsieh wrote:
> >    I'm not that active here, but if you want bigtop setup on
> >    reviews.apache.org all it just takes filing a apache INFRA jira and a
> >    little patience to get it done.  Once it is up, you post patches
> there.
> >     I'm from HBase-land and I generally ask for review board only on
> patches
> >    that are larger than a 1-2 screen-fulls.
> >
> >    Jon.
> >    On Tue, Nov 27, 2012 at 5:08 PM, Mark Grover <
> [EMAIL PROTECTED]>
> >    wrote:
> >
> >      Hi all,
> >      When reviewing Bigtop patches, I often find myself downloading the
> >      patch, applying it to my local repo and using a diff tool on my
> computer
> >      to review the patch (and have some context around it). I know for a
> fact
> >      that some of the other Apache projects are very good about asking
> people
> >      to post reviews on reviewboard (or something similar) when
> uploading a
> >      new patch. That makes the process of reviewing the diff and
> commenting
> >      on patches much easier.
> >      Would it make sense for us to start leveraging something
> >      like https://reviews.apache.org/dashboard/ for this?
> >      Thoughts?
> >      Mark
> >
> >    --
> >    // Jonathan Hsieh (shay)
> >    // Software Engineer, Cloudera
> >    // [EMAIL PROTECTED]
> >
>

--
Apache MRUnit - Unit testing MapReduce - http://incubator.apache.org/mrunit/