Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Zookeeper, mail # dev - Re: Review Request: Dynamic reconfiguration, see https://issues.apache.org/jira/browse/ZOOKEEPER-107
Alexander Shraer
2013-01-21, 22:32
Edward Ribeiro
2013-01-23, 06:57
Copy link to this message
-
Re: Review Request: Dynamic reconfiguration, see https://issues.apache.org/jira/browse/ZOOKEEPER-107
michi@... 2012-12-16, 06:19

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6707/#review13756
-----------------------------------------------------------

/src/c/include/zookeeper.h
<https://reviews.apache.org/r/6707/#comment29430>

    

/src/zookeeper.jute
<https://reviews.apache.org/r/6707/#comment29428>

    

/src/c/include/zookeeper.h
<https://reviews.apache.org/r/6707/#comment30960>

    Could you document the format of the returned data?

/src/c/src/cli.c
<https://reviews.apache.org/r/6707/#comment30955>

    bad indentation?

/src/c/src/cli.c
<https://reviews.apache.org/r/6707/#comment30956>

    Shouldn't it be "serverId=host:port1:port2:port3"? It might be a good idea to give more descriptive names for the ports.

/src/c/src/zookeeper.c
<https://reviews.apache.org/r/6707/#comment30957>

    Don't use STRUCT_INITIALIZER macro.

/src/c/src/zookeeper.c
<https://reviews.apache.org/r/6707/#comment30958>

    bad indentation?

/src/c/src/zookeeper.c
<https://reviews.apache.org/r/6707/#comment30959>

    Don't use STRUCT_INITIALIZER.
- michim
On Nov. 29, 2012, 7:12 a.m., Alexander Shraer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6707/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2012, 7:12 a.m.)
>
>
> Review request for zookeeper.
>
>
> Description
> -------
>
> see https://issues.apache.org/jira/browse/ZOOKEEPER-107
>
>
> Diffs
> -----
>
>   /src/c/include/proto.h 1415037
>   /src/c/include/zookeeper.h 1415037
>   /src/c/src/cli.c 1415037
>   /src/c/src/zookeeper.c 1415037
>   /src/java/main/org/apache/zookeeper/KeeperException.java 1415037
>   /src/java/main/org/apache/zookeeper/ZooDefs.java 1415037
>   /src/java/main/org/apache/zookeeper/ZooKeeper.java 1415037
>   /src/java/main/org/apache/zookeeper/ZooKeeperMain.java 1415037
>   /src/java/main/org/apache/zookeeper/cli/GetConfigCommand.java PRE-CREATION
>   /src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java PRE-CREATION
>   /src/java/main/org/apache/zookeeper/server/DataTree.java 1415037
>   /src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 1415037
>   /src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 1415037
>   /src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java 1415037
>   /src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1415037
>   /src/java/main/org/apache/zookeeper/server/Request.java 1415037
>   /src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java 1415037
>   /src/java/main/org/apache/zookeeper/server/TraceFormatter.java 1415037
>   /src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 1415037
>   /src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 1415037
>   /src/java/main/org/apache/zookeeper/server/quorum/Follower.java 1415037
>   /src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 1415037
>   /src/java/main/org/apache/zookeeper/server/quorum/Leader.java 1415037
>   /src/java/main/org/apache/zookeeper/server/quorum/Learner.java 1415037
>   /src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 1415037
>   /src/java/main/org/apache/zookeeper/server/quorum/Observer.java 1415037
>   /src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 1415037
>   /src/java/main/org/apache/zookeeper/server/quorum/QuorumBean.java 1415037
>   /src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 1415037
>   /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1415037
>   /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 1415037
>   /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 1415037
>   /src/java/main/org/apache/zookeeper/server/quorum/QuorumZooKeeperServer.java 1415037
+
Alexander Shraer 2013-01-21, 22:32
+
Edward Ribeiro 2013-01-23, 06:57