Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request: SQOOP-1076 Sqoop2: Introduce Boolean model type


Copy link to this message
-
Review Request: SQOOP-1076 Sqoop2: Introduce Boolean model type

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11749/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

I've added new model type for Boolean as suggested on the JIRA. In addition I've added two exhaustive tests for all data types (for derby repository and for JSON serialization).
This addresses bug SQOOP-1076.
    https://issues.apache.org/jira/browse/SQOOP-1076
Diffs
-----

  client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java 36509c4eb6071a20efcc2269c79bd455a53debd9
  client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java 95d06122c6f86c163e42d187ebc65cefaa15e77f
  common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 048323b8d5a000e385774cee304e06447612bc1d
  common/src/main/java/org/apache/sqoop/model/FormUtils.java 80b10c803695a7a4578641ac7533b2a7588a0d47
  common/src/main/java/org/apache/sqoop/model/MBooleanInput.java PRE-CREATION
  common/src/main/java/org/apache/sqoop/model/MForm.java cc7d88c1d57f3e5713c2eafe5377fb52cd87ae63
  common/src/main/java/org/apache/sqoop/model/MFormList.java c1c3a414b047b3428440231e1be3d29d1c93131a
  common/src/main/java/org/apache/sqoop/model/MInputType.java 76411e335e6bf7981d483be8fc1fa595bfdc3738
  common/src/test/java/org/apache/sqoop/json/util/TestFormSerialization.java PRE-CREATION
  common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java PRE-CREATION
  core/src/main/java/org/apache/sqoop/repository/Repository.java 21dd759ea0825438de26b3538acca95a72a2a359
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 45a0da4e069e506186a3948cd73032d02724c057
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java PRE-CREATION

Diff: https://reviews.apache.org/r/11749/diff/
Testing
-------

All unit and integration tests seems to be passing.
Thanks,

Jarek Cecho

+
Kathleen Ting 2013-06-23, 00:50