Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Drill >> mail # dev >> Review Request 14027: Adding Limit operator end to end


+
Timothy Chen 2013-09-08, 17:37
+
Timothy Chen 2013-09-10, 08:29
+
Jacques Nadeau 2013-09-18, 18:39
+
Jacques Nadeau 2013-09-19, 01:34
+
Timothy Chen 2013-09-19, 01:14
+
Jacques Nadeau 2013-09-19, 01:04
+
Julian Hyde 2013-09-18, 19:10
+
Timothy Chen 2013-09-21, 00:57
+
Timothy Chen 2013-09-21, 01:13
+
Timothy Chen 2013-09-21, 05:56
+
Julian Hyde 2013-09-27, 16:57
+
Timothy Chen 2013-09-28, 08:01
Copy link to this message
-
Re: Review Request 14027: Adding Limit operator end to end

On Sep 28, 2013, at 1:01 AM, Timothy Chen <[EMAIL PROTECTED]> wrote:

> Here is one of the trials I tried:
>
> -    final RelTraitSet traits = sort.getTraitSet().plus(DrillRel.CONVENTION);
> +    final RelTraitSet traits = sort.getTraitSet();
>     RelNode input = sort.getChild();
>     if (!sort.getCollation().getFieldCollations().isEmpty()) {
>       input = sort.copy(
> -          sort.getTraitSet().replace(RelCollationImpl.EMPTY),
> -          input,
> -          RelCollationImpl.EMPTY,
> +          sort.getTraitSet(),
> +          sort,
> +          sort.getCollation(),
>           null,
>           null);
>     }

The

 +  sort,

line should be

 + input,

otherwise you are creating a sort on top of a sort. Give that a try.

Julian
+
Timothy Chen 2013-09-29, 22:22
+
Timothy Chen 2013-09-29, 22:23
+
Timothy Chen 2013-10-06, 20:09
+
Jacques Nadeau 2013-10-09, 18:00
+
Timothy Chen 2013-10-09, 18:10
+
Jacques Nadeau 2013-10-09, 18:14
+
Timothy Chen 2013-10-10, 17:52
+
Jacques Nadeau 2013-10-10, 17:57
+
Timothy Chen 2013-10-10, 18:20
+
Steven Phillips 2013-09-26, 00:00
+
Timothy Chen 2013-10-11, 03:42
+
Jacques Nadeau 2013-10-11, 18:42
+
Timothy Chen 2013-10-11, 18:58
+
Timothy Chen 2013-10-15, 16:32
+
Timothy Chen 2013-10-15, 22:50
+
Julian Hyde 2013-09-09, 19:11
+
Timothy Chen 2013-09-09, 19:29
+
Julian Hyde 2013-09-09, 19:36