Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 16329: HIVE-6039: Round, AVG and SUM functions reject char/varch input while accepting string input


Copy link to this message
-
Re: Review Request 16329: HIVE-6039: Round, AVG and SUM functions reject char/varch input while accepting string input

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16329/#review30672
-----------------------------------------------------------
Looks good to go. very minor comments added.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java
<https://reviews.apache.org/r/16329/#comment58769>

    Will it be better to explicitly add char and varchar as accepted type in the message?

ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java
<https://reviews.apache.org/r/16329/#comment58770>

    same here.

ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRound.java
<https://reviews.apache.org/r/16329/#comment58771>

    Same. more informative message could be helpful.
- Mohammad Islam
On Dec. 17, 2013, 9:26 p.m., Xuefu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16329/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2013, 9:26 p.m.)
>
>
> Review request for hive and Prasad Mujumdar.
>
>
> Bugs: HIVE-6039
>     https://issues.apache.org/jira/browse/HIVE-6039
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Allow input to these UDFs for char and varchar.
>
>
> Diffs
> -----
>
>   data/files/char_varchar_udf.txt PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java 4b219bd
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java 41d5efd
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRound.java fc9c1b2
>   ql/src/test/queries/clientpositive/char_varchar_udf.q PRE-CREATION
>   ql/src/test/results/clientpositive/char_varchar_udf.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16329/diff/
>
>
> Testing
> -------
>
> Unit tested. New test added. Test suite passed.
>
>
> Thanks,
>
> Xuefu Zhang
>
>