Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Re: Review Request: SQOOP-825 Warning for incorrect usage of hive parameters is not checking HIVE_HOME correctly


Copy link to this message
-
Re: Review Request: SQOOP-825 Warning for incorrect usage of hive parameters is not checking HIVE_HOME correctly

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8918/#review15239
-----------------------------------------------------------

Ship it!
I missed it last time when I was reviewing. Thanks for catching it!

- Cheolsoo Park
On Jan. 10, 2013, 11:43 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8918/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2013, 11:43 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've put the missing "!" into the condition.
>
>
> This addresses bug SQOP-825.
>     https://issues.apache.org/jira/browse/SQOP-825
>
>
> Diffs
> -----
>
>   src/java/org/apache/sqoop/tool/BaseSqoopTool.java c0221c97fc6e2fb971c384ee8e9a7b73915342dc
>
> Diff: https://reviews.apache.org/r/8918/diff/
>
>
> Testing
> -------
>
> I've verified that logs from all unit tests do not show this warning and also run this change on several conditions on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>