Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request 14569: Patch for FLUME-2120


Copy link to this message
-
Re: Review Request 14569: Patch for FLUME-2120
Venkatesh Sivasubramanian... 2013-10-20, 18:11

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14569/
-----------------------------------------------------------

(Updated Oct. 20, 2013, 6:11 p.m.)
Review request for Flume.
Changes
-------

Jeff,
I have rebased the patch against the trunk and have uploaded the latest diff. I noticed the test class that was modified for FLUME-1666 was in TestMultiportSyslogTCPSource and it has test cases for MultiportSyslogTCPSource. So I went ahead and added a separate class TestSyslogTCPSource for SyslogTCPSource.

Thanks
Venkatesh
Bugs: Flume-2120
    https://issues.apache.org/jira/browse/Flume-2120
Repository: flume-git
Description
-------

Pls. find the patch attached for the FLUME-2120.

I have made changes to SyslogUDPSource and SyslogTCPSource. Tested it locally and also have added a JUnit for SyslogUDPSource.
I see the MultiportSyslogTCPSource is pretty much a better version/likely replacement for SyslogTCPSource. But still went ahead and added the metrics counters to SyslogTCPSource, as the change was straight forward and its very much a part of the code base.
Diffs (updated)
-----

  flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java 7a12d27
  flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85
  flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTCPSource.java PRE-CREATION
  flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java eae26ed

Diff: https://reviews.apache.org/r/14569/diff/
Testing
-------

JUnit added for SyslogUDPSource.
Thanks,

Venkatesh Sivasubramanian