Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload


Copy link to this message
-
Re: Review Request: SQOOP-390: PostgreSQL connector for direct export with pg_bulkload
Jarek Cecho 2012-08-09, 07:08

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2724/#review10059
-----------------------------------------------------------
Hi Masatake,
thank you very much for your update. I believe that we're almost at the end!

You've done very good job documenting the usage on JIRA, would you mind updating user guide in similar manner?

Also I do have two comments:
/src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java
<https://reviews.apache.org/r/2724/#comment21295>

    I'm thinking here - is there a situation where the table will exists when you're using unique task id as a part of table name? (except the case where user will actually have such weirdly named table)

/src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java
<https://reviews.apache.org/r/2724/#comment21303>

    I've noticed that class DirectPostgresqlManager have very similar method. Do you think you can reuse it? Or maybe abstract it somewhere as public static?
Thank you very much for your time and effort.

Jarcec

- Jarek Cecho
On Aug. 5, 2012, 6:56 p.m., Masatake Iwasaki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2724/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2012, 6:56 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Patch for SQOOP-390
> https://issues.apache.org/jira/browse/SQOOP-390
>
>
> This addresses bug SQOOP-390.
>     https://issues.apache.org/jira/browse/SQOOP-390
>
>
> Diffs
> -----
>
>   /src/java/org/apache/sqoop/manager/PGBulkloadManager.java PRE-CREATION
>   /src/java/org/apache/sqoop/mapreduce/AutoProgressMapper.java 1367974
>   /src/java/org/apache/sqoop/mapreduce/AutoProgressReducer.java PRE-CREATION
>   /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportJob.java PRE-CREATION
>   /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java PRE-CREATION
>   /src/java/org/apache/sqoop/mapreduce/PGBulkloadExportReducer.java PRE-CREATION
>   /src/java/org/apache/sqoop/mapreduce/ProgressThread.java PRE-CREATION
>   /src/java/org/apache/sqoop/mapreduce/SqoopReducer.java PRE-CREATION
>   /src/test/com/cloudera/sqoop/manager/PGBulkloadManagerManualTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/2724/diff/
>
>
> Testing
> -------
>
> This patch include the test class PGBulkloadManagerTest.
> I've tested "ant test" and passed.
>
>
> Thanks,
>
> Masatake Iwasaki
>
>