Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
HBase >> mail # dev >> Review Request: HBASE-2806 Log a proper error message and don't NPE with broken DNS.


Copy link to this message
-
Review Request: HBASE-2806 Log a proper error message and don't NPE with broken DNS.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/244/
-----------------------------------------------------------

Review request for hbase.
Summary
-------

The code returns null when this happens.  Also, whenever an instance
of HServerAddress is created, the code will verify that the IP can
be retrieved and throw an IllegalArgumentException if it cannot.

This change also fixes some other random little things like:
  - Remove unnecessary parentheses.
  - Remove unnecessary uses of `this' outside of constructors.
  - Missing spaces after `if'.
  - Remove wildcard imports.
  - Remove unnecessary creation of objects.
This addresses bug HBASE-2806.
    http://issues.apache.org/jira/browse/HBASE-2806
Diffs
-----

  trunk/src/main/java/org/apache/hadoop/hbase/HServerAddress.java 959479

Diff: http://review.hbase.org/r/244/diff
Testing
-------

Code compiles.
Thanks,

Benoit