Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request 12593: SQOOP-1141 Sqoop2: Provide ability to enable/disable connections and jobs


Copy link to this message
-
Re: Review Request 12593: SQOOP-1141 Sqoop2: Provide ability to enable/disable connections and jobs
Mengwei Ding 2013-07-24, 17:14


> On July 24, 2013, 2:07 a.m., Jarek Cecho wrote:
> > server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java, lines 60-65
> > <https://reviews.apache.org/r/12593/diff/4/?file=323595#file323595line60>
> >
> >     Adding special semantics to the id do not seem as a clean way to me. I'm not sure what would be better approach, but some suggestions:
> >    
> >     * We could create standalone resources for enabling and disabling objects (for example /v1/enable/job/:jid).
> >     * We could use POST to /v1/connection/:id, but this way we do not have a way how to determine if we want to enable or disable the object
> >     * We could create resource /v1/connection/enable/:xid
> >     * We could create resource /v1/connection/:xid/enable
> >    
> >     What do you think?

Thank you for providing so many options, Jarcec. I am going to take the last one.
- Mengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12593/#review23727
-----------------------------------------------------------
On July 18, 2013, 11:58 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12593/
> -----------------------------------------------------------
>
> (Updated July 18, 2013, 11:58 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-1141
>     https://issues.apache.org/jira/browse/SQOOP-1141
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit ba552918976799d7b7877dc31371274c6a4ba733
> Author: Mengwei Ding <[EMAIL PROTECTED]>
> Date:   Tue Jul 16 10:41:12 2013 -0700
>
>     SQOOP-1141 Sqoop2: Provide ability to enable/disable connections and jobs
>
> :100644 100644 4ca71a4... 158e46c... M client/src/main/java/org/apache/sqoop/client/SqoopClient.java
> :100644 100644 b7b0436... 999790d... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 a69e009... cb7af2e... M client/src/main/java/org/apache/sqoop/client/request/ConnectionRequest.java
> :100644 100644 55ba9db... 77f1341... M client/src/main/java/org/apache/sqoop/client/request/JobRequest.java
> :100644 100644 f102c8f... ffaa84f... M client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java
> :000000 100644 0000000... 5cbd6db... A client/src/main/java/org/apache/sqoop/client/shell/DisableCommand.java
> :000000 100644 0000000... e04292a... A client/src/main/java/org/apache/sqoop/client/shell/DisableConnectionFunction.java
> :000000 100644 0000000... 5962cd2... A client/src/main/java/org/apache/sqoop/client/shell/DisableJobFunction.java
> :000000 100644 0000000... 8a2c1c7... A client/src/main/java/org/apache/sqoop/client/shell/EnableCommand.java
> :000000 100644 0000000... ed6dc3c... A client/src/main/java/org/apache/sqoop/client/shell/EnableConnectionFunction.java
> :000000 100644 0000000... 9e4e320... A client/src/main/java/org/apache/sqoop/client/shell/EnableJobFunction.java
> :100644 100644 32bca71... 94f92b3... M client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
> :100644 100644 590e4e7... 97a240b... M client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
> :100644 100644 aa87f20... f4ea3be... M client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
> :100644 100644 5537a8e... 1a8f963... M client/src/main/resources/client-resource.properties
> :100644 100644 b4e986a... a014ddd... M common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
> :100644 100644 a830646... 4685797... M common/src/main/java/org/apache/sqoop/json/JobBean.java
> :100644 100644 98768d6... ba12b39... M common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
> :100644 100644 137e71c... 5524983... M common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java