Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Hive, mail # dev - Review Request: HIVE-4548 Speed up vectorized LIKE filter for special cases abc%, %abc and %abc%


Copy link to this message
-
Review Request: HIVE-4548 Speed up vectorized LIKE filter for special cases abc%, %abc and %abc%
Teddy Choi 2013-05-17, 14:36

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11222/
-----------------------------------------------------------

Review request for hive.
Description
-------

I edited FilterStringColLikeStringScala.java as Eric Hanson wrote.

For none-complex patterns, it calls a static method that doesn't call others and uses its given byte arrays only. For complex patterns, it reuses a ByteBuffer and a CharBuffer for decoding UTF-8 to avoid object constructions.

There is 30%~170% performance improvement for all cases. Its benchmark result is on https://issues.apache.org/jira/browse/HIVE-4548#comment-13660750.

It still can be more efficient by using a template-driven approach. I'll apply it soon.
This addresses bug HIVE-4548.
    https://issues.apache.org/jira/browse/HIVE-4548
Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterStringColLikeStringScalar.java 24ba861

Diff: https://reviews.apache.org/r/11222/diff/
Testing
-------
Thanks,

Teddy Choi

+
Eric Hanson 2013-05-17, 23:20
+
Teddy Choi 2013-05-21, 12:14
+
Eric Hanson 2013-05-22, 00:00
+
Teddy Choi 2013-05-22, 01:35
+
Teddy Choi 2013-05-28, 01:10
+
Eric Hanson 2013-05-28, 16:31