-
Re: Review Request: FLUME-1682: Improve logging message when encrypted file channel is unable to be initialized due to invalid key/keystoreBrock Noland 2012-12-20, 16:23
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7902/#review14760
-----------------------------------------------------------
ping
- Brock Noland
On Nov. 6, 2012, 7:47 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7902/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2012, 7:47 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> The patch stores a salted SHA-512 hash of the encryption key in the log file metadata. On read that hash is verified and an error message printed out saying there will likely be errors.
>
>
> This addresses bug FLUME-1682.
> https://issues.apache.org/jira/browse/FLUME-1682
>
>
> Diffs
> -----
>
> flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV3.java f768d23
> flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/encryption/EncryptionUtils.java PRE-CREATION
> flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/proto/ProtosFactory.java e6d4957
> flume-ng-channels/flume-file-channel/src/main/proto/filechannel.proto 3a4e828
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/encryption/TestEncryptionUtils.java PRE-CREATION
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/encryption/TestFileChannelEncryption.java d2f5208
>
> Diff: https://reviews.apache.org/r/7902/diff/
>
>
> Testing
> -------
>
> Tests for verification functionality and a unit tests which easily allows you to verify the log message.
>
>
> Thanks,
>
> Brock Noland
>
>
