Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 17200: HIVE-6264: Unbalanced number of HiveParser msgs.push/msgs.pop calls when doing lookahead


Copy link to this message
-
Review Request 17200: HIVE-6264: Unbalanced number of HiveParser msgs.push/msgs.pop calls when doing lookahead

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17200/
-----------------------------------------------------------

Review request for hive.
Bugs: HIVE-6264
    https://issues.apache.org/jira/browse/HIVE-6264
Repository: hive-git
Description
-------

What looks like ANTLR bug causes @after actions to be wrapped in a backtracking check, but the @init action does not have such a check. This results in unbalanced number of push/pop calls to the parser message stack.
Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/FromClauseParser.g 2adefcb
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g c15c4b5
  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 4147503
  ql/src/java/org/apache/hadoop/hive/ql/parse/SelectClauseParser.g f4de252

Diff: https://reviews.apache.org/r/17200/diff/
Testing
-------
Thanks,

Jason Dere