-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8926/
-----------------------------------------------------------

Review request for Flume.
Description
-------

ResettableInputStream should support seek().

This patch makes ResettableInputStream an abstract class instead of an interface, and adds a Seekable interface which is implemented by ResettableInputStream and its subclasses.
This addresses bug FLUME-1828.
    https://issues.apache.org/jira/browse/FLUME-1828
Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableFileInputStream.java f9e4ec9
  flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableInputStream.java ae989a6
  flume-ng-core/src/main/java/org/apache/flume/serialization/Seekable.java PRE-CREATION
  flume-ng-core/src/test/java/org/apache/flume/serialization/ResettableTestStringInputStream.java ef8b7ba

Diff: https://reviews.apache.org/r/8926/diff/
Testing
-------

Unit tests pass.
Thanks,

Mike Percy

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8926/
-----------------------------------------------------------

(Updated Jan. 12, 2013, 12:33 a.m.)
Review request for Flume.
Changes
-------

Fixed a sign bug and added a unit test for seek() and tell().
Description
-------

ResettableInputStream should support seek().

This patch makes ResettableInputStream an abstract class instead of an interface, and adds a Seekable interface which is implemented by ResettableInputStream and its subclasses.
This addresses bug FLUME-1828.
    https://issues.apache.org/jira/browse/FLUME-1828
Diffs (updated)
-----

  flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableFileInputStream.java f9e4ec9
  flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableInputStream.java ae989a6
  flume-ng-core/src/main/java/org/apache/flume/serialization/Seekable.java PRE-CREATION
  flume-ng-core/src/test/java/org/apache/flume/serialization/ResettableTestStringInputStream.java ef8b7ba
  flume-ng-core/src/test/java/org/apache/flume/serialization/TestResettableFileInputStream.java 73e2baa

Diff: https://reviews.apache.org/r/8926/diff/
Testing
-------

Unit tests pass.
Thanks,

Mike Percy

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8926/
-----------------------------------------------------------

(Updated Jan. 12, 2013, 12:34 a.m.)
Review request for Flume.
Description
-------

ResettableInputStream should support seek().

This patch makes ResettableInputStream an abstract class instead of an interface, and adds a Seekable interface which is implemented by ResettableInputStream and its subclasses.
This addresses bug FLUME-1828.
    https://issues.apache.org/jira/browse/FLUME-1828
Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableFileInputStream.java f9e4ec9
  flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableInputStream.java ae989a6
  flume-ng-core/src/main/java/org/apache/flume/serialization/Seekable.java PRE-CREATION
  flume-ng-core/src/test/java/org/apache/flume/serialization/ResettableTestStringInputStream.java ef8b7ba
  flume-ng-core/src/test/java/org/apache/flume/serialization/TestResettableFileInputStream.java 73e2baa

Diff: https://reviews.apache.org/r/8926/diff/
Testing (updated)
-------

Added unit test for seek(). Unit tests pass.
Thanks,

Mike Percy

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8926/#review15284
-----------------------------------------------------------
Looks good, I am running tests.

- Brock Noland
On Jan. 12, 2013, 12:34 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8926/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2013, 12:34 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> ResettableInputStream should support seek().
>
> This patch makes ResettableInputStream an abstract class instead of an interface, and adds a Seekable interface which is implemented by ResettableInputStream and its subclasses.
>
>
> This addresses bug FLUME-1828.
>     https://issues.apache.org/jira/browse/FLUME-1828
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableFileInputStream.java f9e4ec9
>   flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableInputStream.java ae989a6
>   flume-ng-core/src/main/java/org/apache/flume/serialization/Seekable.java PRE-CREATION
>   flume-ng-core/src/test/java/org/apache/flume/serialization/ResettableTestStringInputStream.java ef8b7ba
>   flume-ng-core/src/test/java/org/apache/flume/serialization/TestResettableFileInputStream.java 73e2baa
>
> Diff: https://reviews.apache.org/r/8926/diff/
>
>
> Testing
> -------
>
> Added unit test for seek(). Unit tests pass.
>
>
> Thanks,
>
> Mike Percy
>
>

> On Jan. 12, 2013, 12:42 a.m., Brock Noland wrote:
> > Looks good, I am running tests.

I am seeing some test failures:
Failed tests:   testBasicCommitFailure(org.apache.flume.client.avro.TestSpoolingFileLineReader)
  testBasicCommitFailureAndBufferSizeChanges(org.apache.flume.client.avro.TestSpoolingFileLineReader)
  testMarkReset(org.apache.flume.serialization.TestResettableFileInputStream): expected:<[1. On the planet of Mars](..)

do you get these locally?
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8926/#review15284
-----------------------------------------------------------
On Jan. 12, 2013, 12:34 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8926/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2013, 12:34 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> ResettableInputStream should support seek().
>
> This patch makes ResettableInputStream an abstract class instead of an interface, and adds a Seekable interface which is implemented by ResettableInputStream and its subclasses.
>
>
> This addresses bug FLUME-1828.
>     https://issues.apache.org/jira/browse/FLUME-1828
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableFileInputStream.java f9e4ec9
>   flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableInputStream.java ae989a6
>   flume-ng-core/src/main/java/org/apache/flume/serialization/Seekable.java PRE-CREATION
>   flume-ng-core/src/test/java/org/apache/flume/serialization/ResettableTestStringInputStream.java ef8b7ba
>   flume-ng-core/src/test/java/org/apache/flume/serialization/TestResettableFileInputStream.java 73e2baa
>
> Diff: https://reviews.apache.org/r/8926/diff/
>
>
> Testing
> -------
>
> Added unit test for seek(). Unit tests pass.
>
>
> Thanks,
>
> Mike Percy
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8926/
-----------------------------------------------------------

(Updated Jan. 14, 2013, 9:25 a.m.)
Review request for Flume.
Changes
-------

Updated patch. Thanks for the catch Brock, not sure how I missed it.
Description
-------

ResettableInputStream should support seek().

This patch makes ResettableInputStream an abstract class instead of an interface, and adds a Seekable interface which is implemented by ResettableInputStream and its subclasses.
This addresses bug FLUME-1828.
    https://issues.apache.org/jira/browse/FLUME-1828
Diffs (updated)
-----

  flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableFileInputStream.java f9e4ec9
  flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableInputStream.java ae989a6
  flume-ng-core/src/main/java/org/apache/flume/serialization/Seekable.java PRE-CREATION
  flume-ng-core/src/test/java/org/apache/flume/serialization/ResettableTestStringInputStream.java ef8b7ba
  flume-ng-core/src/test/java/org/apache/flume/serialization/TestResettableFileInputStream.java 73e2baa

Diff: https://reviews.apache.org/r/8926/diff/
Testing
-------

Added unit test for seek(). Unit tests pass.
Thanks,

Mike Percy

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8926/#review15317
-----------------------------------------------------------
OK patch looks good. I will run tests.

- Brock Noland
On Jan. 14, 2013, 9:25 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8926/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2013, 9:25 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> ResettableInputStream should support seek().
>
> This patch makes ResettableInputStream an abstract class instead of an interface, and adds a Seekable interface which is implemented by ResettableInputStream and its subclasses.
>
>
> This addresses bug FLUME-1828.
>     https://issues.apache.org/jira/browse/FLUME-1828
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableFileInputStream.java f9e4ec9
>   flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableInputStream.java ae989a6
>   flume-ng-core/src/main/java/org/apache/flume/serialization/Seekable.java PRE-CREATION
>   flume-ng-core/src/test/java/org/apache/flume/serialization/ResettableTestStringInputStream.java ef8b7ba
>   flume-ng-core/src/test/java/org/apache/flume/serialization/TestResettableFileInputStream.java 73e2baa
>
> Diff: https://reviews.apache.org/r/8926/diff/
>
>
> Testing
> -------
>
> Added unit test for seek(). Unit tests pass.
>
>
> Thanks,
>
> Mike Percy
>
>

> On Jan. 14, 2013, 5:37 p.m., Brock Noland wrote:
> > OK patch looks good. I will run tests.

Hey Mike,

I think the latest patch is missing from the JIRA?

Brock
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8926/#review15317
-----------------------------------------------------------
On Jan. 14, 2013, 9:25 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8926/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2013, 9:25 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> ResettableInputStream should support seek().
>
> This patch makes ResettableInputStream an abstract class instead of an interface, and adds a Seekable interface which is implemented by ResettableInputStream and its subclasses.
>
>
> This addresses bug FLUME-1828.
>     https://issues.apache.org/jira/browse/FLUME-1828
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableFileInputStream.java f9e4ec9
>   flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableInputStream.java ae989a6
>   flume-ng-core/src/main/java/org/apache/flume/serialization/Seekable.java PRE-CREATION
>   flume-ng-core/src/test/java/org/apache/flume/serialization/ResettableTestStringInputStream.java ef8b7ba
>   flume-ng-core/src/test/java/org/apache/flume/serialization/TestResettableFileInputStream.java 73e2baa
>
> Diff: https://reviews.apache.org/r/8926/diff/
>
>
> Testing
> -------
>
> Added unit test for seek(). Unit tests pass.
>
>
> Thanks,
>
> Mike Percy
>
>

> On Jan. 14, 2013, 5:37 p.m., Brock Noland wrote:
> > OK patch looks good. I will run tests.
>
> Brock Noland wrote:
>     Hey Mike,
>    
>     I think the latest patch is missing from the JIRA?
>    
>     Brock

Just uploaded it to the JIRA
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8926/#review15317
-----------------------------------------------------------
On Jan. 14, 2013, 9:25 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8926/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2013, 9:25 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> ResettableInputStream should support seek().
>
> This patch makes ResettableInputStream an abstract class instead of an interface, and adds a Seekable interface which is implemented by ResettableInputStream and its subclasses.
>
>
> This addresses bug FLUME-1828.
>     https://issues.apache.org/jira/browse/FLUME-1828
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableFileInputStream.java f9e4ec9
>   flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableInputStream.java ae989a6
>   flume-ng-core/src/main/java/org/apache/flume/serialization/Seekable.java PRE-CREATION
>   flume-ng-core/src/test/java/org/apache/flume/serialization/ResettableTestStringInputStream.java ef8b7ba
>   flume-ng-core/src/test/java/org/apache/flume/serialization/TestResettableFileInputStream.java 73e2baa
>
> Diff: https://reviews.apache.org/r/8926/diff/
>
>
> Testing
> -------
>
> Added unit test for seek(). Unit tests pass.
>
>
> Thanks,
>
> Mike Percy
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8926/#review15323
-----------------------------------------------------------

Ship it!
Ship It!

- Brock Noland
On Jan. 14, 2013, 9:25 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8926/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2013, 9:25 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> ResettableInputStream should support seek().
>
> This patch makes ResettableInputStream an abstract class instead of an interface, and adds a Seekable interface which is implemented by ResettableInputStream and its subclasses.
>
>
> This addresses bug FLUME-1828.
>     https://issues.apache.org/jira/browse/FLUME-1828
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableFileInputStream.java f9e4ec9
>   flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableInputStream.java ae989a6
>   flume-ng-core/src/main/java/org/apache/flume/serialization/Seekable.java PRE-CREATION
>   flume-ng-core/src/test/java/org/apache/flume/serialization/ResettableTestStringInputStream.java ef8b7ba
>   flume-ng-core/src/test/java/org/apache/flume/serialization/TestResettableFileInputStream.java 73e2baa
>
> Diff: https://reviews.apache.org/r/8926/diff/
>
>
> Testing
> -------
>
> Added unit test for seek(). Unit tests pass.
>
>
> Thanks,
>
> Mike Percy
>
>