Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: SQOOP-734 Change ConnectorBean to send JSON objects rather than sets of arrays


+
Jarek Cecho 2012-12-03, 19:42
Copy link to this message
-
Re: Review Request: SQOOP-734 Change ConnectorBean to send JSON objects rather than sets of arrays
Bilung Lee 2012-12-04, 02:01

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8323/#review14003
-----------------------------------------------------------

Ship it!
Ship It!

- Bilung Lee
On Dec. 3, 2012, 7:42 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8323/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2012, 7:42 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've changed the implementation based on proposal on JIRA.
>
>
> This addresses bug SQOOP-734.
>     https://issues.apache.org/jira/browse/SQOOP-734
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java a34c48c8aa5794bba72cfd6c40fa1b375256e4bb
>   common/src/main/java/org/apache/sqoop/json/ConnectionBean.java c793465fed7847d80d2d91808ed9babba43bf19e
>   common/src/main/java/org/apache/sqoop/json/ConnectorBean.java f630f7521b133691d7acebb5f29717caeabf6ae0
>   common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 3d69bf8609adc431302b9c65aaf2ef2ab60047bc
>   common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java dc8dd95380acaf6689683e505dd4bfb42d6b3224
>   core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 82f88fd917fdbb6dc04b5f241be365a2feb466dc
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 8a522439538da72c23a189454853a0335b8087f3
>
> Diff: https://reviews.apache.org/r/8323/diff/
>
>
> Testing
> -------
>
> * Unit tests are passing
> * Tested on real cluster
>
>
> Thanks,
>
> Jarek Cecho
>
>