Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request: SQOOP-753 Sqoop2: Update top level README file


+
Jarek Cecho 2012-12-10, 20:52
+
Jarek Cecho 2012-12-12, 22:15
+
Cheolsoo Park 2012-12-12, 22:18
Copy link to this message
-
Re: Review Request: SQOOP-753 Sqoop2: Update top level README file

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8445/#review14393
-----------------------------------------------------------
I have some minor comments inline.

Thanks!
README.txt
<https://reviews.apache.org/r/8445/#comment30613>

    How about instead saying the following?
    
    "Sqoop uses the Maven build system, and it can be compiled and built running the following commands:"

README.txt
<https://reviews.apache.org/r/8445/#comment30614>

    How about instead saying the following?
    
    "Sqoop currently supports multiple Hadoop distributions. In order to compile Sqoop against a specific Hadoop version, please specify the hadoop.profile property in Maven commands. For example:"

README.txt
<https://reviews.apache.org/r/8445/#comment30615>

    How about instead saying the following?
    
    "Please refer to the Sqoop documentation for a full list of supported Hadoop distributions and values of the hadoop.profile property."
- Cheolsoo Park
On Dec. 10, 2012, 8:52 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8445/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2012, 8:52 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've updated the README file with up-to-date information.
>
>
> This addresses bug SQOOP-753.
>     https://issues.apache.org/jira/browse/SQOOP-753
>
>
> Diffs
> -----
>
>   README.txt 80d421ec94d909575cd081842719e4eb42a47c36
>
> Diff: https://reviews.apache.org/r/8445/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>