Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume, mail # dev - Review Request: FLUME-924: Implement a JMS source for Flume NG


+
Brock Noland 2012-12-06, 18:34
+
Brock Noland 2012-12-07, 17:55
+
Hari Shreedharan 2012-12-12, 20:21
+
Brock Noland 2012-12-12, 20:27
+
Hari Shreedharan 2012-12-12, 20:41
+
Brock Noland 2012-12-12, 20:45
+
Hari Shreedharan 2012-12-12, 21:00
+
Brock Noland 2012-12-12, 21:26
+
Brock Noland 2012-12-12, 21:27
+
Brock Noland 2012-12-12, 22:13
+
Hari Shreedharan 2012-12-13, 01:23
+
Brock Noland 2012-12-13, 15:35
Copy link to this message
-
Re: Review Request: FLUME-924: Implement a JMS source for Flume NG
Brock Noland 2012-12-13, 15:41

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8369/
-----------------------------------------------------------

(Updated Dec. 13, 2012, 3:41 p.m.)
Review request for Flume.
Changes
-------

Hari,

Thank you for the review! I have updated the patch based on it.

Brock
Description
-------

Implements FLUME-924 (JMS Source). Some notes:

1) Should work for any JMS provider but only tested with ActiveMQ.
2) Has unit tests as well as an ActiveMQ integration test
3) Allows for a pluggable class to convert a JMS message to a Flume Event. With that said, it provides a sensible default implementation.
4) Adds a few abstract classes to core. The purpose of these was to clarify the semantics of the configure, start, stop methods.
5) Adds one protected method to AbtractSource to allow subclasses to set the state. This is used to set the error state when an exception is thrown during start, configure, or stop.
This addresses bug FLUME-924.
    https://issues.apache.org/jira/browse/FLUME-924
Diffs (updated)
-----

  flume-ng-doc/sphinx/FlumeUserGuide.rst 265f546
  flume-ng-sources/flume-jms-source/pom.xml PRE-CREATION
  flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/DefaultJMSMessageConverter.java PRE-CREATION
  flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/InitialContextFactory.java PRE-CREATION
  flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSDestinationType.java PRE-CREATION
  flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSMessageConsumer.java PRE-CREATION
  flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSMessageConsumerFactory.java PRE-CREATION
  flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSMessageConverter.java PRE-CREATION
  flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSource.java PRE-CREATION
  flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSourceConfiguration.java PRE-CREATION
  flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/JMSMessageConsumerTestBase.java PRE-CREATION
  flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestDefaultJMSMessageConverter.java PRE-CREATION
  flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestIntegrationActiveMQ.java PRE-CREATION
  flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestJMSMessageConsumer.java PRE-CREATION
  flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestJMSSource.java PRE-CREATION
  flume-ng-sources/pom.xml 48f751d
  pom.xml 6b465b2

Diff: https://reviews.apache.org/r/8369/diff/
Testing
-------

The tests which were added, pass.
Thanks,

Brock Noland

+
Brock Noland 2012-12-13, 15:42
+
Hari Shreedharan 2012-12-13, 20:58
+
Brock Noland 2012-12-13, 21:25
+
Hari Shreedharan 2012-12-13, 21:37
+
Brock Noland 2012-12-13, 21:46
+
Hari Shreedharan 2012-12-13, 22:01
+
Brock Noland 2012-12-13, 23:47
+
Brock Noland 2012-12-13, 23:47
+
Hari Shreedharan 2012-12-14, 00:00
+
Brock Noland 2012-12-14, 00:39
+
Brock Noland 2012-12-14, 14:30