Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request: Sqoop2: Print out warnings in client shell for objects created with status ACCEPTABLE


Copy link to this message
-
Re: Review Request: Sqoop2: Print out warnings in client shell for objects created with status ACCEPTABLE

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9729/#review17376
-----------------------------------------------------------
Hi Vasant,
thank you very much for working on this!
client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java
<https://reviews.apache.org/r/9729/#comment36891>

    Would you mind putting this logic to some util class rather than to SqoopFunction? There is couple of output functions in FormDisplayer class already, so it might be a good candidate.

client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java
<https://reviews.apache.org/r/9729/#comment36892>

    I'm currently working on a patch that will make this "instanceof" much siimpler as it will introduce common ancestor to both MConnection and Mjob classes.

client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java
<https://reviews.apache.org/r/9729/#comment36893>

    Can we make it more "user friendly"? Something like saying "there were some issues, here is their list, but hey, don't worry, we saved the object anyway".
Jarcec

- Jarek Cecho
On March 4, 2013, 8:53 a.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9729/
> -----------------------------------------------------------
>
> (Updated March 4, 2013, 8:53 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Print out warnings in client shell for objects created with status ACCEPTABLE
>
>
> This addresses bug SQOOP-920.
>     https://issues.apache.org/jira/browse/SQOOP-920
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java 2c750d3
>   client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java 1f01cc7
>   client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java 5632bac
>   client/src/main/java/org/apache/sqoop/client/shell/UpdateConnectionFunction.java dd0df24
>   client/src/main/java/org/apache/sqoop/client/shell/UpdateJobFunction.java 4fac977
>
> Diff: https://reviews.apache.org/r/9729/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>