Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request 13035: SQOOP-744: log4j configuration for generated mapreduce job


Copy link to this message
-
Re: Review Request 13035: SQOOP-744: log4j configuration for generated mapreduce job


> On July 29, 2013, 6:10 p.m., Jarek Cecho wrote:
> > Hi Raghav,
> > thank you for working on this JIRA! It seems that the logger is being configured only from Mapper and Reducer, so I'm wondering if there is reason why other top level entities (Input and Output formats for example) were skipped?

I am trying to run configureLogging method() once per jvm before any sqoop logging happens. My thinking was that SqoopMapper, SqoopReducer class would get at least loaded triggering configureLogging() before any actual logging happens. Let me know if that is not the case i.e. there are classes that might want to use sqoop logging before SqoopMapper, SqoopReducer class files are loaded.
- Raghav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13035/#review24193
-----------------------------------------------------------
On July 29, 2013, 3:32 p.m., Raghav Gautam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13035/
> -----------------------------------------------------------
>
> (Updated July 29, 2013, 3:32 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-744
>     https://issues.apache.org/jira/browse/SQOOP-744
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Adding log4j.properties for the generated job.
>
>
> Diffs
> -----
>
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java f5f6d8e
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 59cf391
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java b31161c
>   execution/mapreduce/src/main/resources/META-INF/log4j.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13035/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> Thanks,
>
> Raghav Gautam
>
>