Marcio Silva 2012-03-09, 12:03
Miki Tebeka 2012-03-13, 19:23
Marcio O Silva 2012-03-14, 02:53
Miki Tebeka 2012-03-14, 03:49
Doug Cutting 2012-03-14, 18:22
Miki Tebeka 2012-03-14, 20:31
Scott Carey 2012-03-14, 21:53
Miki Tebeka 2012-03-15, 03:56
Doug Cutting 2012-03-14, 20:43
On 03/13/2012 12:23 PM, Miki Tebeka wrote:
> I other question, I *do* have commit rights but very green to the
> development process. Is there a document somewhere that I can refer
There are some instructions at:
If we find that document is missing things then we should update it.
The general flow is something like:
0. An issue is opened in Jira. Potential solutions are discussed.
1. Someone provides a patch in Jira and marks it as "Patch Available".
2. A committer reviews the patch.
3. If the reviewer feels it's not ready for commit, reasons are given
and we return to step (0) or (1).
4. If the patch is acceptable, it is committed and the Jira issue is
While reviews are nice to get before commits, we don't strictly require
a review before every commit. Often committers will say, either of
their own patch or that of someone else, "I'll commit this tomorrow
unless someone objects", then, if no one speaks up, they commit it. For
trivial, uncontroversial changes like fixing typos, folks often just
commit them immediately.
Does this help?
Miki Tebeka 2012-03-13, 23:23