Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Drill, mail # dev - Review Request 14027: Adding Limit operator end to end


+
Timothy Chen 2013-09-08, 17:37
+
Timothy Chen 2013-09-10, 08:29
+
Jacques Nadeau 2013-09-18, 18:39
+
Jacques Nadeau 2013-09-19, 01:34
+
Timothy Chen 2013-09-19, 01:14
+
Jacques Nadeau 2013-09-19, 01:04
+
Julian Hyde 2013-09-18, 19:10
+
Timothy Chen 2013-09-21, 00:57
+
Timothy Chen 2013-09-21, 01:13
+
Timothy Chen 2013-09-21, 05:56
+
Julian Hyde 2013-09-27, 16:57
+
Timothy Chen 2013-09-28, 08:01
+
Julian Hyde 2013-09-29, 22:01
+
Timothy Chen 2013-09-29, 22:22
+
Timothy Chen 2013-09-29, 22:23
+
Timothy Chen 2013-10-06, 20:09
+
Jacques Nadeau 2013-10-09, 18:00
+
Timothy Chen 2013-10-09, 18:10
+
Jacques Nadeau 2013-10-09, 18:14
+
Timothy Chen 2013-10-10, 17:52
+
Jacques Nadeau 2013-10-10, 17:57
+
Timothy Chen 2013-10-10, 18:20
+
Steven Phillips 2013-09-26, 00:00
+
Timothy Chen 2013-10-11, 03:42
Copy link to this message
-
Re: Review Request 14027: Adding Limit operator end to end
Jacques Nadeau 2013-10-11, 18:42

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14027/#review26936
-----------------------------------------------------------

exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/limit/LimitRecordBatch.java
<https://reviews.apache.org/r/14027/#comment52463>

    As far as I can tell, you still proceed to retrieve all record batches even if we're just doing a simple select * limit 10 query.  One of the main purposes of that query is to avoid reading that data.  You need to kill the incoming record batch once you've read everything you need.
- Jacques Nadeau
On Oct. 11, 2013, 3:42 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14027/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2013, 3:42 a.m.)
>
>
> Review request for drill and Jacques Nadeau.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Adding Limit operator end to end
>
>
> Diffs
> -----
>
>   LICENSE 5234110
>   common/src/main/java/org/apache/drill/common/JSONOptions.java 8157dc6
>   common/src/main/java/org/apache/drill/common/logical/data/Constant.java e05ce41
>   common/src/main/java/org/apache/drill/common/logical/data/Limit.java 93eb182
>   common/src/main/java/org/apache/drill/common/logical/data/LogicalOperator.java 9810e75
>   common/src/main/java/org/apache/drill/common/logical/data/LogicalOperatorBase.java 29c994f
>   exec/java-exec/src/main/java/org/apache/drill/exec/opt/BasicOptimizer.java 5a1fd6e
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java 286144b
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java a36b65a
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/Limit.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java 94acc0e
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/limit/LimitBatchCreator.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/limit/LimitRecordBatch.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/StatsCollector.java 0368d0c
>   exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestSimpleLimit.java PRE-CREATION
>   exec/java-exec/src/test/resources/limit/test1.json PRE-CREATION
>   exec/java-exec/src/test/resources/limit/test2.json PRE-CREATION
>   exec/java-exec/src/test/resources/limit/test3.json PRE-CREATION
>   exec/ref/src/main/java/org/apache/drill/exec/ref/rops/LimitROP.java 00baf81
>   pom.xml ce1f93d
>   sqlparser/src/main/java/org/apache/drill/optiq/DrillImplementor.java 6efe60b
>   sqlparser/src/main/java/org/apache/drill/optiq/DrillLimitRel.java PRE-CREATION
>   sqlparser/src/main/java/org/apache/drill/optiq/DrillLimitRule.java PRE-CREATION
>   sqlparser/src/main/java/org/apache/drill/optiq/DrillOptiq.java b01aa7d
>   sqlparser/src/main/java/org/apache/drill/optiq/DrillPrepareImpl.java 363c064
>   sqlparser/src/main/java/org/apache/drill/optiq/DrillSortRel.java b2e9b50
>   sqlparser/src/main/java/org/apache/drill/optiq/DrillSortRule.java d5eac2e
>   sqlparser/src/test/java/org/apache/drill/jdbc/test/FullEngineTest.java 45d1ff3
>   sqlparser/src/test/java/org/apache/drill/jdbc/test/JdbcAssert.java e78d5c7
>   sqlparser/src/test/java/org/apache/drill/jdbc/test/JdbcTest.java 36b024c
>
> Diff: https://reviews.apache.org/r/14027/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Timothy Chen
>
>

+
Timothy Chen 2013-10-11, 18:58
+
Timothy Chen 2013-10-15, 16:32
+
Timothy Chen 2013-10-15, 22:50
+
Julian Hyde 2013-09-09, 19:11
+
Timothy Chen 2013-09-09, 19:29
+
Julian Hyde 2013-09-09, 19:36