Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo >> mail # dev >> Review Request 15166: ACCUMULO-802 Tablespaces


Copy link to this message
-
Re: Review Request 15166: ACCUMULO-802 Tablespaces

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15166/#review28554
-----------------------------------------------------------

core/src/main/java/org/apache/accumulo/core/client/TableNamespaceExistsException.java
<https://reviews.apache.org/r/15166/#comment55352>

    I would like to see this (and the other two exceptions) all extend RuntimeException. I think that since these are all conditions that can be checked for before attempting operations, it is unnecessarily burdensome on the client to force additional checked Exceptions on them.

core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperations.java
<https://reviews.apache.org/r/15166/#comment55355>

    Minor nit on inconsistent parameter naming - "permission" everywhere else in the codebase.

core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperations.java
<https://reviews.apache.org/r/15166/#comment55356>

    Please do not introduce whitespace errors.

core/src/main/java/org/apache/accumulo/core/client/admin/TableNamespaceOperations.java
<https://reviews.apache.org/r/15166/#comment55357>

    Should TableOperations and TabletOpoerations share a common super-interface?

core/src/main/java/org/apache/accumulo/core/client/admin/TableNamespaceOperations.java
<https://reviews.apache.org/r/15166/#comment55359>

    I don't understand what this method does. Sets the default existance of versioning iterator on tables created in the namespace? That seems like maybe too broad of a setting to expose through this API?

core/src/main/java/org/apache/accumulo/core/client/admin/TableNamespaceOperationsImpl.java
<https://reviews.apache.org/r/15166/#comment55366>

    If an error happens with a table in the middle of the list, then we're left in a half-cloned state. Probably better to clean up after ourselves.

core/src/main/java/org/apache/accumulo/core/client/admin/TableNamespaceOperationsImpl.java
<https://reviews.apache.org/r/15166/#comment55371>

    What happens if you attempt to offline a namespace while somebody else moves a table from one namespace into another? What _should_ happen?

core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java
<https://reviews.apache.org/r/15166/#comment55383>

    Can we ignore the whitespace changes?

core/src/main/java/org/apache/accumulo/core/client/impl/TableNamespaces.java
<https://reviews.apache.org/r/15166/#comment55388>

    Is there value in making this a SortedMap? Why not just Map?

core/src/main/java/org/apache/accumulo/core/client/impl/Tables.java
<https://reviews.apache.org/r/15166/#comment55389>

    No.
- Mike Drob
On Nov. 1, 2013, 2:01 a.m., Christopher Tubbs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15166/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 2:01 a.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-802
>     https://issues.apache.org/jira/browse/ACCUMULO-802
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-802 Tablespaces (Table Namespaces), work done by Sean Hickey, https://github.com/Wisellama/accumulo/tree/ACCUMULO-802, rebase'd onto latest master (including 210 commits)
>
>
> Diffs
> -----
>
>   core/src/main/java/org/apache/accumulo/core/Constants.java 9db0c405c5b9fbac13fa735c3ffd6433e9831051
>   core/src/main/java/org/apache/accumulo/core/client/Connector.java bbfa55f4b9ad8fc0e5f0c0058e2e0564685d7c85
>   core/src/main/java/org/apache/accumulo/core/client/TableNamespaceExistsException.java PRE-CREATION
>   core/src/main/java/org/apache/accumulo/core/client/TableNamespaceNotEmptyException.java PRE-CREATION
>   core/src/main/java/org/apache/accumulo/core/client/TableNamespaceNotFoundException.java PRE-CREATION
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperations.java 86a3ff271fc2e085c426da3156cfab9cdbb5c36b