Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: SQOOP-659. Design metadata upgrade procedure


Copy link to this message
-
Re: Review Request: SQOOP-659. Design metadata upgrade procedure
Jarek Cecho 2013-04-18, 20:52

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10281/#review19408
-----------------------------------------------------------
Hi Hari, the updated patch looks great, thank you very much for the refactoring. I do have just few final minor notes:
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorMetadataUpgrader.java
<https://reviews.apache.org/r/10281/#comment40117>

    I would recommend transferring only the values. Status messages should not be transferred as we should do our own validation before serialization (not in scope of this jira though).

core/src/main/java/org/apache/sqoop/repository/Repository.java
<https://reviews.apache.org/r/10281/#comment40119>

    I think that this guy will be running in different transaction as the main tx is not propagated here.

core/src/main/java/org/apache/sqoop/repository/Repository.java
<https://reviews.apache.org/r/10281/#comment40120>

    I think that this guy will be running in different transaction as the main tx is not propagated here.
Jarcec

- Jarek Cecho
On April 18, 2013, 6:15 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10281/
> -----------------------------------------------------------
>
> (Updated April 18, 2013, 6:15 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Metadata upgrade for connector upgrades. This is an initial patch soliciting feedback. Limited testing has been done. I will add some unit tests once I get feedback.
>
>
> This addresses bug SQOOP-659.
>     https://issues.apache.org/jira/browse/SQOOP-659
>
>
> Diffs
> -----
>
>   common/src/main/java/org/apache/sqoop/model/MConnection.java 36dca42
>   common/src/main/java/org/apache/sqoop/model/MJob.java a53f04e
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java c315e48
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorMetadataUpgrader.java PRE-CREATION
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 32df1e5
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ca51313
>   core/src/main/java/org/apache/sqoop/repository/Repository.java d6ec303
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 95f6570
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 32cef8a
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java ea458ac
>   spi/src/main/java/org/apache/sqoop/connector/spi/MetadataUpgrader.java PRE-CREATION
>   spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 540303a
>
> Diff: https://reviews.apache.org/r/10281/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Shreedharan
>
>