Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request 14250: HIVE-4957: Restrict number of bit vectors, to prevent out of Java heap memory


Copy link to this message
-
Re: Review Request 14250: HIVE-4957: Restrict number of bit vectors, to prevent out of Java heap memory
Shreepadma Venugopalan 2013-10-01, 21:17


> On Sept. 20, 2013, 8:38 p.m., Carl Steinbach wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java, line 480
> > <https://reviews.apache.org/r/14250/diff/2/?file=354856#file354856line480>
> >
> >     Please use a static variable instead of repeating "1024":
> >    
> >     private static final MAX_NUM_BIT_VECTORS = 1024;

1024 is not repeated within a class. However, we can repeat the constant declaration across classes instead.
> On Sept. 20, 2013, 8:38 p.m., Carl Steinbach wrote:
> > ql/src/test/queries/clientnegative/compute_stats_long.q, line 6
> > <https://reviews.apache.org/r/14250/diff/2/?file=354857#file354857line6>
> >
> >     Why should it raise an error?

Added a longer comment.
- Shreepadma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14250/#review26304
-----------------------------------------------------------
On Sept. 20, 2013, 8:02 p.m., Shreepadma Venugopalan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14250/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2013, 8:02 p.m.)
>
>
> Review request for hive and Brock Noland.
>
>
> Bugs: HIVE-4957
>     https://issues.apache.org/jira/browse/HIVE-4957
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Restricts the number of bit vectors used by Flajolet-Martin distinct value estimator to 1024.
>
>
> Diffs
> -----
>
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java 63110bb
>   ql/src/test/queries/clientnegative/compute_stats_long.q PRE-CREATION
>   ql/src/test/results/clientnegative/compute_stats_long.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14250/diff/
>
>
> Testing
> -------
>
> Adds a new negative test case.
>
>
> Thanks,
>
> Shreepadma Venugopalan
>
>