| clear query|facets|time |
Search criteria: .
Results from 51 to 60 from
194 (2.753s).
|
|
|
Loading phrases to help you
refine your search...
|
|
Re: Comment from Martin Fowler - Zookeeper - [mail # dev]
|
|
...the tests aren't green dude! that is exactly what i proposed waiting for. ben On Wed, Nov 2, 2011 at 2:57 AM, Thomas Koch wrote:...
|
|
|
Author: Benjamin Reed,
2011-11-02, 13:26
|
|
|
Zab1.0 - Apache ZooKeeper - Apache Software Foundation - Zookeeper - [wiki]
|
|
... Comment: Go to start of metadata &nb...
|
|
|
https://cwiki.apache.org/confluence/display/ZOOKEEPER/Zab1.0
Author: Benjamin Reed,
2011-11-02, 00:00
|
|
|
Re: Better testing for client code... - Zookeeper - [mail # dev]
|
|
...i second the need for such a mocked ZooKeeper client! there are a couple of failure cases to test in an application that uses ZooKeeper, but we don't provide a good library to generate them....
|
|
|
Author: Benjamin Reed,
2011-11-01, 18:58
|
|
|
Re: cleanup and subjective patches - Zookeeper - [mail # dev]
|
|
...those pieces of code are core to the system. as i said for reasonsearlier, risking destabilizing them to make the code look prettier forsome definition of pretty does not seem wise to me. ch...
|
|
|
Author: Benjamin Reed,
2011-11-01, 04:39
|
|
|
Re: cleanup and subjective patches - Zookeeper - [mail # dev]
|
|
...that isn't really middle ground. adding new tests for code is added functionality, so it would be a valid patch under the criteria i suggested. changing an int to an enum is not adding funct...
|
|
|
Author: Benjamin Reed,
2011-10-31, 23:28
|
|
|
Re: cleanup and subjective patches - Zookeeper - [mail # dev]
|
|
...deprioritizing them doesn't help because the patches themselves bit rot. shortly they will not apply and then they will be worthless. the poor contributor would then be left with the task of...
|
|
|
Author: Benjamin Reed,
2011-10-31, 21:15
|
|
|
cleanup and subjective patches - Zookeeper - [mail # dev]
|
|
...i know we have discussed this in the past, but we never really came to a consensus or policy, so i'd like to reopen the discussion on cleanup and subjective patches. currently there ar...
|
|
|
Author: Benjamin Reed,
2011-10-31, 21:06
|
|
|
Re: Why does multi-op check operation increment zxid? - Zookeeper - [mail # dev]
|
|
...to be honest it is lines like this - switch (hdr.getType()) { - case OpCode.createSess...
|
|
|
Author: Benjamin Reed,
2011-10-25, 21:05
|
|
|
Re: Why does multi-op check operation increment zxid? - Zookeeper - [mail # dev]
|
|
...i was thinking mostly in terms of the code itself. enums are great for structures that aren't serialized, but when you do serialize it, you end up having to force specific values into the en...
|
|
|
Author: Benjamin Reed,
2011-10-24, 05:31
|
|
|
Re: Why does multi-op check operation increment zxid? - Zookeeper - [mail # dev]
|
|
...i think you found the bug because you reviewed that code to convert to enum. is there something inherit to using enums that helped? i don't think it is wise to use enum when many (most perha...
|
|
|
Author: Benjamin Reed,
2011-10-21, 22:32
|
|
|
|
